FFVPXRuntimeLinker::Init() should set sLinkStatus to LinkStatus_FAILED before returning false

RESOLVED FIXED in Firefox 47

Status

()

Core
Audio/Video: Playback
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
As we do in FFmpegRuntimeLinker::Init().
(Assignee)

Comment 1

2 years ago
Otherwise the 2nd call might hit the assertion |MOZ_ASSERT(NS_IsMainThread())| if the 1st call fails.
Assignee: nobody → jwwang
(Assignee)

Comment 2

2 years ago
Created attachment 8713003 [details]
MozReview Request: Bug 1243627 - FFVPXRuntimeLinker::Init() should set sLinkStatus to LinkStatus_FAILED before returning false. r=jya.

Review commit: https://reviewboard.mozilla.org/r/32735/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32735/
Attachment #8713003 - Flags: review?(jyavenard)
Comment on attachment 8713003 [details]
MozReview Request: Bug 1243627 - FFVPXRuntimeLinker::Init() should set sLinkStatus to LinkStatus_FAILED before returning false. r=jya.

https://reviewboard.mozilla.org/r/32735/#review29541

Much easier to set sLinkStatus = LinkStatus_FAILED; before starting any processing

prevent duplicating this line everywhere.
Attachment #8713003 - Flags: review?(jyavenard)
(Assignee)

Comment 4

2 years ago
Comment on attachment 8713003 [details]
MozReview Request: Bug 1243627 - FFVPXRuntimeLinker::Init() should set sLinkStatus to LinkStatus_FAILED before returning false. r=jya.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32735/diff/1-2/
Attachment #8713003 - Flags: review?(jyavenard)
Comment on attachment 8713003 [details]
MozReview Request: Bug 1243627 - FFVPXRuntimeLinker::Init() should set sLinkStatus to LinkStatus_FAILED before returning false. r=jya.

https://reviewboard.mozilla.org/r/32735/#review29543
Attachment #8713003 - Flags: review?(jyavenard) → review+
(Assignee)

Comment 6

2 years ago
Thanks!
Priority: -- → P2

Comment 7

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d74069d5dd46

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d74069d5dd46
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.