Closed
Bug 1243627
Opened 8 years ago
Closed 8 years ago
FFVPXRuntimeLinker::Init() should set sLinkStatus to LinkStatus_FAILED before returning false
Categories
(Core :: Audio/Video: Playback, defect, P2)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
Details
Attachments
(1 file)
As we do in FFmpegRuntimeLinker::Init().
Assignee | ||
Comment 1•8 years ago
|
||
Otherwise the 2nd call might hit the assertion |MOZ_ASSERT(NS_IsMainThread())| if the 1st call fails.
Assignee: nobody → jwwang
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/32735/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/32735/
Attachment #8713003 -
Flags: review?(jyavenard)
Comment 3•8 years ago
|
||
Comment on attachment 8713003 [details] MozReview Request: Bug 1243627 - FFVPXRuntimeLinker::Init() should set sLinkStatus to LinkStatus_FAILED before returning false. r=jya. https://reviewboard.mozilla.org/r/32735/#review29541 Much easier to set sLinkStatus = LinkStatus_FAILED; before starting any processing prevent duplicating this line everywhere.
Attachment #8713003 -
Flags: review?(jyavenard)
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8713003 [details] MozReview Request: Bug 1243627 - FFVPXRuntimeLinker::Init() should set sLinkStatus to LinkStatus_FAILED before returning false. r=jya. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32735/diff/1-2/
Attachment #8713003 -
Flags: review?(jyavenard)
Comment 5•8 years ago
|
||
Comment on attachment 8713003 [details] MozReview Request: Bug 1243627 - FFVPXRuntimeLinker::Init() should set sLinkStatus to LinkStatus_FAILED before returning false. r=jya. https://reviewboard.mozilla.org/r/32735/#review29543
Attachment #8713003 -
Flags: review?(jyavenard) → review+
Assignee | ||
Comment 6•8 years ago
|
||
Thanks!
Updated•8 years ago
|
Priority: -- → P2
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d74069d5dd46
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•