1243627 - FFVPXRuntimeLinker::Init() should set sLinkStatus to LinkStatus_FAILED before returning false

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[JW Wang [:jwwang] [:jw_wang]]

As we do in FFmpegRuntimeLinker::Init().

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Otherwise the 2nd call might hit the assertion |MOZ_ASSERT(NS_IsMainThread())| if the 1st call fails.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1243627 - FFVPXRuntimeLinker::Init() should set sLinkStatus to LinkStatus_FAILED before returning false. r=jya.

Review commit: https://reviewboard.mozilla.org/r/32735/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32735/

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8713003 [details]
MozReview Request: Bug 1243627 - FFVPXRuntimeLinker::Init() should set sLinkStatus to LinkStatus_FAILED before returning false. r=jya.

https://reviewboard.mozilla.org/r/32735/#review29541

Much easier to set sLinkStatus = LinkStatus_FAILED; before starting any processing

prevent duplicating this line everywhere.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8713003 [details]
MozReview Request: Bug 1243627 - FFVPXRuntimeLinker::Init() should set sLinkStatus to LinkStatus_FAILED before returning false. r=jya.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32735/diff/1-2/

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8713003 [details]
MozReview Request: Bug 1243627 - FFVPXRuntimeLinker::Init() should set sLinkStatus to LinkStatus_FAILED before returning false. r=jya.

https://reviewboard.mozilla.org/r/32735/#review29543

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d74069d5dd46

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d74069d5dd46