Closed
Bug 1243630
Opened 8 years ago
Closed 8 years ago
Moar logging from batch submit API
Categories
(MozReview Graveyard :: General, defect)
MozReview Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gps, Assigned: gps)
Details
Attachments
(1 file)
As part of investigating bug 1202309 it was pretty obvious that we need more server-side logging around what the batch submit API is doing.
Assignee | ||
Comment 1•8 years ago
|
||
This should help us establish a better audit trail and will help us debug issues, including basic timing information. Review commit: https://reviewboard.mozilla.org/r/32739/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/32739/
Attachment #8713023 -
Flags: review?(smacleod)
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8713023 [details] MozReview Request: mozreview: more logging for batch review request API (bug 1243630); r?dminor Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32739/diff/1-2/
Attachment #8713023 -
Attachment description: MozReview Request: mozreview: more logging for batch review request API (bug 1243630); r?smacleod → MozReview Request: mozreview: more logging for batch review request API (bug 1243630); r?dminor
Attachment #8713023 -
Flags: review?(smacleod) → review?(dminor)
Comment 3•8 years ago
|
||
Comment on attachment 8713023 [details] MozReview Request: mozreview: more logging for batch review request API (bug 1243630); r?dminor https://reviewboard.mozilla.org/r/32739/#review29969 ::: pylib/mozreview/mozreview/resources/batch_review_request.py:275 (Diff revision 2) > + logging.exception('submission exception') Assuming e.value has something meaningful in it, you might as well log it here.
Attachment #8713023 -
Flags: review?(dminor) → review+
Assignee | ||
Comment 4•8 years ago
|
||
https://reviewboard.mozilla.org/r/32739/#review29969 > Assuming e.value has something meaningful in it, you might as well log it here. logging.exception() will automagically add details about the current exception from sys.exc_info().
Assignee | ||
Comment 5•8 years ago
|
||
Autolanded.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Developer Services → MozReview
You need to log in
before you can comment on or make changes to this bug.
Description
•