1243630 - Moar logging from batch submit API

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Gregory Szorc [:gps]]

As part of investigating bug 1202309 it was pretty obvious that we need more server-side logging around what the batch submit API is doing.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozreview: more logging for batch review request API (bug 1243630); r?dminor

This should help us establish a better audit trail and will help us
debug issues, including basic timing information.

Review commit: https://reviewboard.mozilla.org/r/32739/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32739/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8713023 [details]
MozReview Request: mozreview: more logging for batch review request API (bug 1243630); r?dminor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32739/diff/1-2/

Comment 3

[Dan Minor [:dminor]]

Comment on attachment 8713023 [details]
MozReview Request: mozreview: more logging for batch review request API (bug 1243630); r?dminor

https://reviewboard.mozilla.org/r/32739/#review29969

::: pylib/mozreview/mozreview/resources/batch_review_request.py:275
(Diff revision 2)
> +            logging.exception('submission exception')

Assuming e.value has something meaningful in it, you might as well log it here.

Comment 4

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/32739/#review29969

> Assuming e.value has something meaningful in it, you might as well log it here.

logging.exception() will automagically add details about the current exception from sys.exc_info().

Comment 5

[Gregory Szorc [:gps]]

Autolanded.