1243657 - [IMM] When there is only composition string in editor, canceling the composition causes painting caret at odd position (right-most of the editor)

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Alice0775 White]

The problem happens
1. Microsoft IME and Microsoft Office 2010 as well
2. TSF off
3. "半角英数" 入力モード
4. ESC key will move caret to the beginning of 1st line


Steps To Reproduce:
1. Choose MS-IME for default IME
2-1. Open "Microsoft IMEのプロパティ" > "全般"
2-2. Choose "半角英数" of 初期入力モード 
2-3. Switch tab "和英混在入力"
2-4. Turn on "英字をローマ字から漢字変換する(主に英語を入力する)" 
2-5. OK

4. Start Firefox with TSF off
5. Open web page incl. input field.
   e.g. data:text/html,<input type="text">
5. Forcus input field
6. Right click on the field. And Enable "Check Spelling"
7. IME on and Choose conversion mode to "半角英数(P)"
8. Type word and then [ESC]

Actual Results:
Caret jumps to the end of line

Expected Results:
Caret should be at the start of line

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=13aa9ac1791e&tochange=4631a7474d8a

Regressed by: Bug 1077345

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I don't understand the STR well. Could you exmplain about #8?

I tried to type "abc" and then, type Escape key, then, the composition string is canceled normally.

Comment 2

[Alice0775 White]

(In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #1)
> I don't understand the STR well. Could you exmplain about #8?
> 
> I tried to type "abc" and then, type Escape key, then, the composition
> string is canceled normally.

Yes, the composition string  is canceled, but caret jump to the end

Comment 3

[Alice0775 White]

Attachment: screencast.wmv

Comment 4

[Alice0775 White]

MS-IME2012 and Google日本語入力(2.17.2400.0) on Windows8.1(VM) is affected.
MS-IME and Google日本語入力(2.17.2400.0) on Windows10 build11099(VM) is also affected.

Comment 5

[Alice0775 White]

Corrected. This occurs regardless of the IME input mode.  


Steps To Reproduce:
1. Start Firefox with TSF off
2. Open web page incl. input field.
   e.g. data:text/html,<input type="text">
3. Forcus input field
4. Right click on the field. And Enable "Check Spelling"
5. IME on
6. Type abc and then [ESC]

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I have another question, do you reproduce this with <textarea> or something contenteditable element? I mean, this might be a bug related to autocomplete.

Comment 7

[Alice0775 White]

I cannot reproduce with [1],[2].

[1] data:text/html,<div contenteditable style="border:1px solid red;height:100px"></div>
[2] data:text/html,<textarea>

Comment 8

[Alice0775 White]

I will change the status to trivial, because there are no functioning problems except the caret position.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thank you very much. I can now reproduce this bug on both Win7 and Win10. But I'm still not sure what's the cause... (Why does this only occur with IMM???)

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: spellchecker should check if IME composition works as deleting whole text

This is a bug of spell checker.

mozInlineSpellStatus::InitForEditorChange() may be called with removed text node. This may occur at deleteSelection or insertIMEText. For the former, the method handles correctly. However, it doesn't assume insertIMEText deletes text node. If there is no text except composition string, canceling the composition may cause removing the text node. Then, |mAnchorRange->ComparePoint(aPreviousNode, aPreviousOffset, &cmpResult)| fails and failing InitForEditorChange() causes skipping CreateBogusNodeIfNeeded(), CreateTrailingBRIfNeeded() and CollapseSelectionToTrailingBRIfNeeded() in nsTextEditRules::AfterEdit(). This is the cause of odd caret position.

Although, I'm not sure if this bug isn't reproducible in TSF mode...

Comment 11

[(no longer active)]

Comment on attachment 8713467 [details] [diff] [review]
spellchecker should check if IME composition works as deleting whole text

Review of attachment 8713467 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!  Is it possible to add a test for this?

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to :Ehsan Akhgari from comment #11)
> Thanks!  Is it possible to add a test for this?

Maybe, maybe not, because I don't understand the cause completely since this won't be reproduced with TSF mode... Anyway, I'll try to do it later when I have much time.

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e22bed8364ad9066dec0b619e77bcda503493d38
Bug 1243657 spellchecker should check if IME composition works as deleting whole text r=ehsan

Comment 14

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e22bed8364ad