1243681 - OmxDataDecoder hard-codes component port indices.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[John Lin [:jhlin][:jolin]]

OpenMAX IL spec defines port indices for every standard components using "port base". Clients should query the number from component through OMX_GetParameter() to calculate port indices.

Comment 1

[John Lin [:jhlin][:jolin]]

Attachment: MozReview Request: Bug 1243681 - Query port base and calculate index with it. r?alfredo

Review commit: https://reviewboard.mozilla.org/r/35427/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35427/

Comment 2

[John Lin [:jhlin][:jolin]]

Comment on attachment 8720685 [details]
MozReview Request: Bug 1243681 - Query port base and calculate index with it. r?alfredo

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35427/diff/1-2/

Comment 3

[John Lin [:jhlin][:jolin]]

(In reply to John Lin [:jolin][:jhlin] from comment #2)
> Comment on attachment 8720685 [details]
> MozReview Request: Bug 1243681 - Query port base and calculate index with
> it. r?alfredo
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/35427/diff/1-2/

 Update the code for getting port indices.

Comment 4

[Alfredo Yang (:alfredo)]

https://reviewboard.mozilla.org/r/35425/#review32263

Overall it looks good to me except for the uninitialized port number.

Comment 5

[John Lin [:jhlin][:jolin]]

Comment on attachment 8720685 [details]
MozReview Request: Bug 1243681 - Query port base and calculate index with it. r?alfredo

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35427/diff/2-3/

Comment 6

[John Lin [:jhlin][:jolin]]

(In reply to Alfredo Yang (:alfredo) from comment #4)
> https://reviewboard.mozilla.org/r/35425/#review32263
> 
> Overall it looks good to me except for the uninitialized port number.

 Thanks a lot for the review. Fixed in patch v3.

Comment 7

[Alfredo Yang (:alfredo)]

Comment on attachment 8720685 [details]
MozReview Request: Bug 1243681 - Query port base and calculate index with it. r?alfredo

https://reviewboard.mozilla.org/r/35427/#review32261

LGTM

::: dom/media/platforms/omx/OmxPlatformLayer.h:88
(Diff revision 1)
> +  OMX_U32 mStartPortNumber;

mStartPortNumber is uninitialized before Config().

Comment 8

[John Lin [:jhlin][:jolin]]

Comment on attachment 8720685 [details]
MozReview Request: Bug 1243681 - Query port base and calculate index with it. r?alfredo

https://reviewboard.mozilla.org/r/35427/#review32629

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7989e73486d1

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7989e73486d1