OmxDataDecoder hard-codes component port indices.

RESOLVED FIXED in Firefox 47

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jhlin, Assigned: jhlin)

Tracking

Trunk
mozilla47
Unspecified
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
OpenMAX IL spec defines port indices for every standard components using "port base". Clients should query the number from component through OMX_GetParameter() to calculate port indices.
Assignee

Updated

3 years ago
Assignee

Comment 2

3 years ago
Comment on attachment 8720685 [details]
MozReview Request: Bug 1243681 - Query port base and calculate index with it. r?alfredo

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35427/diff/1-2/
Assignee

Comment 3

3 years ago
(In reply to John Lin [:jolin][:jhlin] from comment #2)
> Comment on attachment 8720685 [details]
> MozReview Request: Bug 1243681 - Query port base and calculate index with
> it. r?alfredo
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/35427/diff/1-2/

 Update the code for getting port indices.
https://reviewboard.mozilla.org/r/35425/#review32263

Overall it looks good to me except for the uninitialized port number.
Assignee

Comment 5

3 years ago
Comment on attachment 8720685 [details]
MozReview Request: Bug 1243681 - Query port base and calculate index with it. r?alfredo

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35427/diff/2-3/
Assignee

Comment 6

3 years ago
(In reply to Alfredo Yang (:alfredo) from comment #4)
> https://reviewboard.mozilla.org/r/35425/#review32263
> 
> Overall it looks good to me except for the uninitialized port number.

 Thanks a lot for the review. Fixed in patch v3.
Comment on attachment 8720685 [details]
MozReview Request: Bug 1243681 - Query port base and calculate index with it. r?alfredo

https://reviewboard.mozilla.org/r/35427/#review32261

LGTM

::: dom/media/platforms/omx/OmxPlatformLayer.h:88
(Diff revision 1)
> +  OMX_U32 mStartPortNumber;

mStartPortNumber is uninitialized before Config().
Attachment #8720685 - Flags: review?(ayang) → review+
Assignee

Comment 8

3 years ago
Comment on attachment 8720685 [details]
MozReview Request: Bug 1243681 - Query port base and calculate index with it. r?alfredo

https://reviewboard.mozilla.org/r/35427/#review32629
Attachment #8720685 - Flags: review+

Comment 10

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7989e73486d1
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.