1243708 - Autoland should land commits with the landing date instead of the original date

Status: NEW

(Conduit :: Lando, defect, P3)

Description

[Xidorn Quan [:xidorn] UTC+11]

I think autoland should change the date of the commit to the current time instead of leaving its original date, because that could make history rather confusing.

For example, the mislanded patch of bug 1229437. [1] It was initially created on 21 Dec 2015, and it landed on 27 Jan 2016. I found it pretty hard to locate this commit in the commit history on GitHub.

I suggest autoland should update the date to the current date before landing. Probably it can inherit the original timezone of the date, which should be preferable.

[1] https://hg.mozilla.org/integration/mozilla-inbound/rev/4dd7ad84ece9

Comment 1

[Gregory Szorc [:gps]]

I agree.

It's worth noting that by default `git log` shows in reverse chronological order (as opposed to say topological order, like hg). Updating the commit time to the current time will make `git log` output much more sane. It will also enable easier querying/searching of commits [by date] (although Mercurial can query by pushlog dates via the "mozext" extension).

Comment 2

[Mark Côté [:mcote]]

We're a bit better now, as the time recorded in commits landed with Lando is the last modification time to the Phabricator revision (generally, this is when the reviewer accepted it).  We could have Lando use the time it was queued for landing instead.