Remove non needed methods in dom/ipc/ContentParent*

RESOLVED INVALID

Status

()

RESOLVED INVALID
3 years ago
3 years ago

People

(Reporter: amarchesini, Assigned: amarchesini)

Tracking

39 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 8713168 [details] [diff] [review]
aa.patch
Attachment #8713168 - Flags: review?(bugs)
Attachment #8713168 - Flags: review?(bugs)
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INVALID

Comment 1

3 years ago
Comment on attachment 8713168 [details] [diff] [review]
aa.patch

># HG changeset patch
># User Andrea Marchesini <amarchesini@mozilla.com>
># Parent  211a4c710fb6af2cad10102c4cabc7cb525998b8
>
>diff --git a/dom/ipc/ContentParent.cpp b/dom/ipc/ContentParent.cpp
>--- a/dom/ipc/ContentParent.cpp
>+++ b/dom/ipc/ContentParent.cpp
>@@ -4782,23 +4782,16 @@ ContentParent::CheckAppHasStatus(unsigne
> 
> bool
> ContentParent::KillChild()
> {
>   KillHard("KillChild");
>   return true;
> }
> 
>-PBlobParent*
>-ContentParent::SendPBlobConstructor(PBlobParent* aActor,
>-                                    const BlobConstructorParams& aParams)
>-{
>-  return PContentParent::SendPBlobConstructor(aActor, aParams);
>-}
>-

So this compiles everywhere and all?
SendPBlobConstructor is something which PContentParent and nsIContentParent both have, but
nsIContentParent has it as pure virtual;

(we have SendPBlobConstructor also in ContentBridgeParent)

Comment 2

3 years ago
aha, invalid it is
You need to log in before you can comment on or make changes to this bug.