1243751 - Create marionette js test for video FF/REW control

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[No-Jun Park [:njpark]]

We need a marionette test that checks to see the FF/REW button are working properly

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] npark-mozilla:1243751 > mozilla-b2g:master

Comment 2

[No-Jun Park [:njpark]]

Comment on attachment 8713463 [details] [review]
[gaia] npark-mozilla:1243751 > mozilla-b2g:master

This script checks that Rew/FF buttons increment by +-10 seconds each, and resumes playback when play button is tapped.

Comment 3

[Russ Nicoletti [:russn]]

Comment on attachment 8713463 [details] [review]
[gaia] npark-mozilla:1243751 > mozilla-b2g:master

Thanks for writing this test, No-Jun. It's good to see the video app get more test coverage. I'm not giving r+ because I'd like you to explore whether one issue I commented on in the PR about whether it's necessary to always wait two seconds when pausing the video. Please let me know if you have any questions about my comments. Thanks!

Comment 4

[Punam Dahiya [:pdahiya]]

Comment on attachment 8713463 [details] [review]
[gaia] npark-mozilla:1243751 > mozilla-b2g:master

Hi No-Jun
I have updated PR with my feedback.  I am good with Russ reviewing the final patch.

Thanks!

Comment 5

[No-Jun Park [:njpark]]

Comment on attachment 8713463 [details] [review]
[gaia] npark-mozilla:1243751 > mozilla-b2g:master

I incorporated all of your suggestions.

Comment 6

[No-Jun Park [:njpark]]

Ah, just saw comment 4. removing review request for Punam.

Comment 7

[Russ Nicoletti [:russn]]

Comment on attachment 8713463 [details] [review]
[gaia] npark-mozilla:1243751 > mozilla-b2g:master

I've added a couple more comments in the PR, the changes look good.

Comment 8

[No-Jun Park [:njpark]]

Merged:
https://github.com/mozilla-b2g/gaia/commit/81bda8c8053551f50c310958161598d0b2121f7b