remove skip-if lines for mulet

RESOLVED FIXED in Firefox 47

Status

defect
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: linclark, Assigned: linclark)

Tracking

Trunk
Firefox 47
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
Right now we have skip-ifs for mulet next to individual tests in browser.ini files. However, :ochameau says that we can skip all of the devtools tests for mulet.

I believe we should put in place a folder level skip-if (if it isn't already there) and then remove the individual skip-ifs.

Any other opinions?
:ochameau, do you if any of "extra" responsive design modes for FxOS are only tested on Mulet?  (Probably not tested anywhere...)

If we truly don't want the tests to run at all on Mulet with no chance of that changing soon, it might be better to work with releng so that DevTools test runs just aren't scheduled at all for Mulet.  At least for the DevTools browser chrome tests, they are in their own test job, so it would be easy to turn those off independently, saving resources.

I guess we would still need some skip-ifs for any chrome and xpcshell tests, since those run together with the rest of the tree.
Flags: needinfo?(poirot.alex)
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #1)
> :ochameau, do you if any of "extra" responsive design modes for FxOS are
> only tested on Mulet?  (Probably not tested anywhere...)

Not tested...

> If we truly don't want the tests to run at all on Mulet with no chance of
> that changing soon, it might be better to work with releng so that DevTools
> test runs just aren't scheduled at all for Mulet.  At least for the DevTools
> browser chrome tests, they are in their own test job, so it would be easy to
> turn those off independently, saving resources.

Yes. I think it is just useless ressources being spent, even more since the recent announcements around b2g.

> I guess we would still need some skip-ifs for any chrome and xpcshell tests,
> since those run together with the rest of the tree.

This is different for non-browser tests. Testing the client/UI/frontend part on b2g products isn't important. It would just cover displaying devtools on Mulet.
Testing server/actors on the backend, on b2g, is more relevant. I would *not* agressively disable them on b2g/mulet. Mulet is the simulator, we would like to keep it working until b2g is completely deprecated. We would turn these tests off once other teams also shut them down.
Flags: needinfo?(poirot.alex)
Assignee

Comment 3

3 years ago
I've created an issue in the releng queue, Bug 1244932. Once that's done, I'll go through and remove the individual skip-ifs.
Assignee: nobody → lclark
Status: NEW → ASSIGNED
Depends on: 1244932
Assignee

Updated

3 years ago
Summary: skip-if all devtools tests on mulet → remove skip-if lines for mulet
Assignee

Comment 4

3 years ago
The other issue revealed that our tests aren't being run on mulet anyway, so we can remove all of the skip-if lines now.

Completed try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5042fc32393d&selectedJob=16191756
Attachment #8714856 - Flags: review?(jryans)
Attachment #8714856 - Flags: review?(jryans) → review+
Assignee

Updated

3 years ago
Keywords: checkin-needed

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e1f885b79aac
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.