Closed Bug 1243781 Opened 8 years ago Closed 8 years ago

Push methods called from a worker should reject with a DOMException

Categories

(Core :: DOM: Notifications, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: lina, Assigned: lina)

References

Details

Attachments

(1 file)

This was fixed in bug 1206302 for main thread calls, but worker calls reject with wrapped nsresults instead of DOM exceptions.

At some point, we should consider moving Push.js into C++ to avoid inconsistencies like this, but that's a yak shave for another day.
Attachment #8713226 - Flags: review?(martin.thomson) → review+
Comment on attachment 8713226 [details]
MozReview Request: Bug 1243781 - Push methods called from a worker should reject with a `DOMException`. r?mt

https://reviewboard.mozilla.org/r/32777/#review29611
https://hg.mozilla.org/mozilla-central/rev/6d13649d2f01
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
backed out since we still have perma failures like https://treeherder.mozilla.org/logviewer.html#?job_id=3216622&repo=mozilla-central
Flags: needinfo?(kcambridge)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Flags: needinfo?(kcambridge)
https://hg.mozilla.org/mozilla-central/rev/7a380cf6ed96
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: