Validate iOS uses Android list of search engines per locale

RESOLVED FIXED in 4.0

Status

()

Firefox for iOS
General
P5
enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kar, Assigned: bnicholson)

Tracking

unspecified
Other
Other
Dependency tree / graph

Firefox Tracking Flags

(fxios3.0+, fxios-v3.0 fixed, fxios-v4.0 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
 **Requirements:**

- 
We’ve had a number of complaints from people around the world that they want to use DDG but they can’t because right now we only ship a predefined list of engines per locale without the ability to add new items.

- Need to validate that iOS and Android use the same list of search engines that have been validated by local communities  

**User Stories:**

- As a user, I want to have [a decent set of search engines] available in my my predefined list  

**Acceptance Criteria:**

- Android and iOS use the same list of search engines  

**KPIs / Measurements Used:**

-   

**Additional Info:**

-
Assignee: nobody → jhugman
Assignee: jhugman → nobody
Assignee: nobody → bnicholson
tracking-fxios: --- → 3.0+
Hey Brian can you just check if we still use the same list on iOS as we use on Android. And if not, re-import it.
(Assignee)

Comment 2

2 years ago
Doing a preliminary import, I see that only cs (Czech) and zh-TW (Chinese/Taiwan) have been updated to include DDG.

I've also seen a few reports of missing DDG, and those I saw (neither of the above) simply didn't have duckduckgo in the locale's list.txt: `grep -rl duckduckgo . | wc -l` shows that only 17 of the 74 locales currently include it.

So being on par with Android will fix the two locales mentioned above, but the initial bug report sounds like we might want to cover more. If that's the case, this isn't iOS-specific, and we should file an l10n bug to make sure these locales are updated on both platforms.

Karen, do you know which locale(s) in particular we want to update?
Flags: needinfo?(krudnitski)
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
(In reply to Brian Nicholson (:bnicholson) from comment #2)
> So being on par with Android will fix the two locales mentioned above, but
> the initial bug report sounds like we might want to cover more. If that's
> the case, this isn't iOS-specific, and we should file an l10n bug to make
> sure these locales are updated on both platforms.

Just remember that this is not one bug, it's X bugs, where X is the number of locales we support on Fennec and don't have DDG. And it will take weeks, if not months to fix.

If you want to add this to iOS, I'd suggest to patch list.txt to include DDG in firefox-ios if missing. For example desktop adds DDG at build time for all locales; at the time we started shipping DDG, it was decided to manually include only a handful of locales in Fennec and not going that way.

Last note: the real issue is that on iOS you can't manage searchplugins and add your own, unlike Fennec.
(Reporter)

Comment 4

2 years ago
As a first step, I'd like to ensure that the search engine list (pre-installed) for iOS is the same as the pre-installed list for Android.

Can we get that audit done first, and then we'll know what search engines need updating? Joanne should also be kept in the loop in case specific codes are required.
Flags: needinfo?(krudnitski)
(Assignee)

Comment 5

2 years ago
Created attachment 8724973 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1585

Besides myself, I think Stefan and Richard have touched plugins the most!
Attachment #8724973 - Flags: review?(sarentz)
Attachment #8724973 - Flags: review?(rnewman)
(Assignee)

Comment 6

2 years ago
Note that the SearchOverlays/wikipedia.xml overlay (which includes an updated Wikipedia icon) and the SearchOverlays/zh-CN/list.txt override (which changes the list of zh-CN engines) should probably be pushed upstream to the Android repos since these don't seem iOS-specific. I'll make sure the appropriate bugs are filed.
(Assignee)

Comment 7

2 years ago
The first case has already been handled by bug 1179109. That bug updates all of the Wikipedia assets to a 96x96 icon (even though the XML shows 16x16). We're using a 90x90 image on iOS, so our current Wikipedia assets are slightly worse quality than the ones on Android. Since it looks like Android has mostly switched over to the higher-res icon, I propose we drop the Wikipedia icon we're using on iOS and just pull in Android's. Filed bug 1252286 to do this.
(Assignee)

Comment 8

2 years ago
Filed bug 1252289 to push the zh-CN list to Android. We can remove our zh-CN list.txt override once that's fixed.
(In reply to Brian Nicholson (:bnicholson) from comment #7)
> Since it looks like Android has mostly switched over to the higher-res icon

Nit: Wikipedia was completely switched to 96px
https://l10n.mozilla-community.org/~flod/p12n/bug1179109_highres_fennec/
Attachment #8724973 - Flags: review?(rnewman) → review+
(Assignee)

Comment 10

2 years ago
https://github.com/mozilla/firefox-ios/commit/ca841afbb158ec35d87088432b595d7660324475
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.0
(Assignee)

Comment 11

2 years ago
v3.x: https://github.com/mozilla/firefox-ios/commit/f6a848ad93a14e2183c9b1de3530d9f09d480505
status-fxios-v3.0: --- → fixed
status-fxios-v4.0: --- → fixed
(Assignee)

Updated

2 years ago
Attachment #8724973 - Flags: review?(sarentz)
(Assignee)

Updated

2 years ago
Depends on: 1254646
(Assignee)

Updated

2 years ago
Depends on: 1268994
You need to log in before you can comment on or make changes to this bug.