1243907 - Don't query _BITS enums on GL Core profiles

Status: RESOLVED FIXED

(Core :: Canvas: WebGL, defect)

Description

[Jeff Gilbert [:jgilbert]]

Attachment: 0002-Don-t-query-GL_-_BITS-on-Core-profiles.patch

The _BITS enums don't exist in Core profiles.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8713370 [details] [diff] [review]
0002-Don-t-query-GL_-_BITS-on-Core-profiles.patch

Review of attachment 8713370 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLContextState.cpp
@@ +109,5 @@
> +        switch (pname) {
> +        case LOCAL_GL_RED_BITS:
> +        case LOCAL_GL_GREEN_BITS:
> +        case LOCAL_GL_BLUE_BITS:
> +            *out_val = 8;

What about 565?

Comment 2

[Jeff Gilbert [:jgilbert]]

Comment on attachment 8713370 [details] [diff] [review]
0002-Don-t-query-GL_-_BITS-on-Core-profiles.patch

Review of attachment 8713370 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLContextState.cpp
@@ +109,5 @@
> +        switch (pname) {
> +        case LOCAL_GL_RED_BITS:
> +        case LOCAL_GL_GREEN_BITS:
> +        case LOCAL_GL_BLUE_BITS:
> +            *out_val = 8;

It's actually out-of-spec to give back a 565/4444 backbuffer. The WebGL 1 spec requires at least 8 bits per channel.

I don't think we should worry about this.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

What about situations where the framebuffer is higher precision than 8,8,8,8?

Comment 4

[Jeff Gilbert [:jgilbert]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> What about situations where the framebuffer is higher precision than 8,8,8,8?

This doesn't happen yet.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/78bd3a5e7968

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/78bd3a5e7968