Closed
Bug 1243925
Opened 8 years ago
Closed 8 years ago
Extra white space in JIT view
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox47 fixed)
RESOLVED
FIXED
Firefox 47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: jsantell, Assigned: vporof)
References
Details
Attachments
(2 files)
5.97 KB,
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
2.62 MB,
application/json
|
Details |
Reporter | ||
Comment 1•8 years ago
|
||
Moving ni? from bug 1243925 to here -- can you take this?
Flags: needinfo?(vporof)
Reporter | ||
Comment 2•8 years ago
|
||
This is the main blocker for the jit view
Assignee | ||
Comment 3•8 years ago
|
||
Yup, keeping the needinfo open for now though.
Assignee | ||
Comment 4•8 years ago
|
||
Triaging. Filter on LULUGUBRIOUSUS.
Flags: needinfo?(vporof)
Priority: -- → P2
Assignee | ||
Updated•8 years ago
|
Priority: P2 → P1
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•8 years ago
|
||
Jordan, I can't seem to get the JIT view to show up. I have devtools.performance.ui.show-jit-optimizations set to true but I can never find a node in the call tree that ends up showing the optimizations.
Flags: needinfo?(jsantell)
Reporter | ||
Comment 6•8 years ago
|
||
Try saving a profile from octane benchmarks, where functions are fired 100+ times to get in ion; should have a grey bubble next to the frames that have data; if not, sounds like a bug
Flags: needinfo?(jsantell)
Assignee | ||
Comment 7•8 years ago
|
||
There's a fixed height div.bottom-spacer node (2590px) that's being inserted at the bottom of the tree... What?
Reporter | ||
Comment 9•8 years ago
|
||
Here's a profile with some optimizations. I'm still seeing some weirdness, can't STR, but going between frames and scrolling causes the following inconsistently: * When switching from one (longish) frame with opts to a (shortish) frame with opts, the scroll bar is at the very bottom with lots of white space needed to scroll up to see the one or two lines at the very top (from a lot of white space at the bottom) * Less of an issue, but sometimes scrolling can cause no rows to be rendered, unless resizing/scrolling slowly. This was occurring in the memory tree, but I thought that was fixed? Are these issues related to this fix, or something else?
Assignee | ||
Comment 10•8 years ago
|
||
I don't see any of those issues. Can you provide some STR? Which frames did you click in that profile?
Assignee | ||
Comment 11•8 years ago
|
||
(In reply to Jordan Santell [:jsantell] [@jsantell] (Please needinfo) from comment #9) > > Are these issues related to this fix, or something else? I doubt it, but have no way to prove it since I can't reproduce anything.
Reporter | ||
Updated•8 years ago
|
Attachment #8725791 -
Flags: review?(jsantell) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 12•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e99bde8d254
Keywords: checkin-needed
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9e99bde8d254
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•