Closed Bug 1243925 Opened 8 years ago Closed 8 years ago

Extra white space in JIT view

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)

defect

Tracking

(firefox47 fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: jsantell, Assigned: vporof)

References

Details

Attachments

(2 files)

Moving ni? from bug 1243925 to here -- can you take this?
Flags: needinfo?(vporof)
This is the main blocker for the jit view
Yup, keeping the needinfo open for now though.
Triaging. Filter on LULUGUBRIOUSUS.
Flags: needinfo?(vporof)
Priority: -- → P2
Priority: P2 → P1
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Jordan, I can't seem to get the JIT view to show up. I have devtools.performance.ui.show-jit-optimizations set to true but I can never find a node in the call tree that ends up showing the optimizations.
Flags: needinfo?(jsantell)
Try saving a profile from octane benchmarks, where functions are fired 100+ times to get in ion; should have a grey bubble next to the frames that have data; if not, sounds like a bug
Flags: needinfo?(jsantell)
There's a fixed height div.bottom-spacer node (2590px) that's being inserted at the bottom of the tree... What?
Attached patch v1Splinter Review
Also cleaned up.
Attachment #8725791 - Flags: review?(jsantell)
Attached file opts.json
Here's a profile with some optimizations.

I'm still seeing some weirdness, can't STR, but going between frames and scrolling causes the following inconsistently:

* When switching from one (longish) frame with opts to a (shortish) frame with opts, the scroll bar is at the very bottom with lots of white space needed to scroll up to see the one or two lines at the very top (from a lot of white space at the bottom)
* Less of an issue, but sometimes scrolling can cause no rows to be rendered, unless resizing/scrolling slowly. This was occurring in the memory tree, but I thought that was fixed?

Are these issues related to this fix, or something else?
I don't see any of those issues. Can you provide some STR? Which frames did you click in that profile?
(In reply to Jordan Santell [:jsantell] [@jsantell] (Please needinfo) from comment #9)
> 
> Are these issues related to this fix, or something else?

I doubt it, but have no way to prove it since I can't reproduce anything.
Attachment #8725791 - Flags: review?(jsantell) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9e99bde8d254
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.