Closed
Bug 1243982
Opened 8 years ago
Closed 8 years ago
[e10s] Enable browser_webconsole_closure_inspection.js in e10s
Categories
(DevTools :: Console, defect, P1)
DevTools
Console
Tracking
(e10s+, firefox47 affected, firefox48 fixed)
RESOLVED
FIXED
Firefox 48
People
(Reporter: linclark, Assigned: bgrins)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
No description provided.
Updated•8 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
Assignee | ||
Updated•8 years ago
|
Priority: -- → P1
Assignee | ||
Comment 1•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9eea38922ec6
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/41543/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/41543/
Attachment #8733087 -
Flags: review?(lclark)
Reporter | ||
Updated•8 years ago
|
Attachment #8733087 -
Flags: review?(lclark) → review+
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8733087 [details] MozReview Request: Bug 1243982 - Enable browser_webconsole_closure_inspection.js in e10s;r=linclark https://reviewboard.mozilla.org/r/41543/#review38185 ::: devtools/client/webconsole/test/browser_webconsole_closure_inspection.js:32 (Diff revision 1) > } > > loadTab(TEST_URI).then(() => { > openConsole().then((hud) => { > openDebugger().then(({ toolbox, panelWin }) => { > let deferred = promise.defer(); Might want to switch this to Promise (unless deferred is required in this instance). But I also know that we want to enable these tests quickly, so ok to commit as is.
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/00b9f30c26f4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•