1244080 - Add an automation test for bug 1235478

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

The test was dropped from bug 1235286 because the test causes intermittent failure without the fix for bug 1235478.

The fix for bug 1235478 will be landed soon.  We need the test!

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Part 0: Remove unnecessary argument for remove().

This patch is actually related to this issue.
I did leave an unnecessary argument on each remove() call. This patch removes them, and fix a typo in test name.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Part 1: Test that setting duration in the middle of the animation causes only once a restyling

This is the test.

Comment 3

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Comment on attachment 8714239 [details] [diff] [review]
Part 1: Test that setting duration in the middle of the animation causes only once a restyling

Review of attachment 8714239 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/animation/test/chrome/test_restyles.html
@@ +321,5 @@
>         'never cause restyles after pause() is called');
>      div.remove();
>    });
>  
> +  add_task_if_omta_enabled(function* only_one_restyling_when_current_time_is_set_to_middle_of_duration() {

Nit: It would be nice if we could wrap this line to < 80 chars, but that might be difficult.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

(In reply to Brian Birtles (:birtles, busy 1~9 Feb) from comment #3)
> ::: dom/animation/test/chrome/test_restyles.html
> @@ +321,5 @@
> >         'never cause restyles after pause() is called');
> >      div.remove();
> >    });
> >  
> > +  add_task_if_omta_enabled(function* only_one_restyling_when_current_time_is_set_to_middle_of_duration() {
> 
> Nit: It would be nice if we could wrap this line to < 80 chars, but that
> might be difficult.

I did try to change it to other styles, but all of them were weird. I leave the line as it for now.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ee7ba63dfb2

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/43075083cae0
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d4d6831a8c3

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/43075083cae0
https://hg.mozilla.org/mozilla-central/rev/2d4d6831a8c3