Closed
Bug 1244149
Opened 8 years ago
Closed 8 years ago
Build error: workspace/gecko/b2g/app/nsBrowserApp.cpp:284: error: undefined reference to 'mozilla::LogModule::Init()'
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ferjm, Assigned: fabrice)
References
Details
(Keywords: smoketest)
Attachments
(1 file)
862 bytes,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
It seems that Bug 1219482 caused the following build error: https://treeherder.mozilla.org/logviewer.html#?job_id=15996099&repo=try
Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(sajitk)
Flags: needinfo?(erahm)
Assignee | ||
Comment 1•8 years ago
|
||
I'm working on the fix.
Comment 2•8 years ago
|
||
it was backed out for other failures. FYI.
Assignee | ||
Comment 3•8 years ago
|
||
I checked that each process goes through NS_InitXPCOM2() in XPCOMInit.cpp where we already call mozilla::LogModule::Init()
Assignee: nobody → fabrice
Attachment #8713729 -
Flags: review?(nfroyd)
![]() |
||
Comment 4•8 years ago
|
||
Comment on attachment 8713729 [details] [diff] [review] log_init.patch Review of attachment 8713729 [details] [diff] [review]: ----------------------------------------------------------------- r=me, thanks!
Attachment #8713729 -
Flags: review?(nfroyd) → review+
Comment 5•8 years ago
|
||
Sorry for the bustage, this is an unfortunate instance of try runs w/ '-p all' no longer building b2g by default.
Flags: needinfo?(erahm)
![]() |
||
Comment 6•8 years ago
|
||
(In reply to Eric Rahm [:erahm] from comment #5) > Sorry for the bustage, this is an unfortunate instance of try runs w/ '-p > all' no longer building b2g by default. They do build, they're just no longer shown, e.g.: https://treeherder.mozilla.org/#/jobs?repo=try&revision=04e9ad55c7bf&exclusion_profile=false&selectedJob=16102012 The switch is the square button next to the "tiers" drop down menu.
Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(sajitk)
Comment 7•8 years ago
|
||
I guess we can close this: bug 1219482 relanded on mozilla-central without the offending change.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•