1244149 - Build error: workspace/gecko/b2g/app/nsBrowserApp.cpp:284: error: undefined reference to 'mozilla::LogModule::Init()'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

It seems that Bug 1219482 caused the following build error:

https://treeherder.mozilla.org/logviewer.html#?job_id=15996099&repo=try

Comment 1

[[:fabrice] Fabrice Desré]

I'm working on the fix.

Comment 2

[Hubert Figuiere [:hub]]

it was backed out for other failures. FYI.

Comment 3

[[:fabrice] Fabrice Desré]

Attachment: log_init.patch

I checked that each process goes through NS_InitXPCOM2() in XPCOMInit.cpp where we already call mozilla::LogModule::Init()

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8713729 [details] [diff] [review]
log_init.patch

Review of attachment 8713729 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks!

Comment 5

[Eric Rahm [:erahm]]

Sorry for the bustage, this is an unfortunate instance of try runs w/ '-p all' no longer building b2g by default.

Comment 6

[Nathan Froyd [:froydnj]]

(In reply to Eric Rahm [:erahm] from comment #5)
> Sorry for the bustage, this is an unfortunate instance of try runs w/ '-p
> all' no longer building b2g by default.

They do build, they're just no longer shown, e.g.:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=04e9ad55c7bf&exclusion_profile=false&selectedJob=16102012

The switch is the square button next to the "tiers" drop down menu.

Comment 7

[:gerard-majax]

I guess we can close this: bug 1219482 relanded on mozilla-central without the offending change.