Closed Bug 1244160 Opened 5 years ago Closed 4 years ago

Create json-schema for build telemetry data

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: dminor, Assigned: dminor)

References

Details

Attachments

(1 file)

The telemetry team has asked for a json schema for data we'll be submitting to telemetry.

My impression is that this is to protect themselves from bad data in their "pipeline". Since we're not asking them to do any processing at this point, I'm going to create a minimalist schema for now.

We can lock things done further once we've done some iterations on what we're going to be reporting and especially in the case we get them to do more processing on what is being submitted.
Assignee: nobody → dminor
Status: NEW → ASSIGNED
This adds a simple schema for build telemetry data. We can make it more
restrictive once we have a better feeling for what kind of data we want
to submit.

This also moves more common data about the system to the telemetry handler.
We leave psutil derivied information in the resource usage data as not every
system will have psutil installed.

Review commit: https://reviewboard.mozilla.org/r/35145/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35145/
Attachment #8719865 - Flags: review?(gps)
Attachment #8719865 - Flags: feedback?(rmiller)
Comment on attachment 8719865 [details]
MozReview Request: Bug 1244160 - Create json-schema for build telemetry data r?gps

https://reviewboard.mozilla.org/r/35145/#review31737

::: python/mozbuild/mozbuild/resources/html-build-viewer/index.html:59
(Diff revision 1)
> -  if (data.version != 1 && data.version != 2) {
> +  if (data.version != 1 && data.version != 2 && data.version != 3) {

Might as well use <= and >=.
Attachment #8719865 - Flags: review?(gps) → review+
Comment on attachment 8719865 [details]
MozReview Request: Bug 1244160 - Create json-schema for build telemetry data r?gps

LGTM
Attachment #8719865 - Flags: feedback?(rmiller) → feedback+
Comment on attachment 8719865 [details]
MozReview Request: Bug 1244160 - Create json-schema for build telemetry data r?gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35145/diff/1-2/
Attachment #8719865 - Flags: feedback+
https://hg.mozilla.org/mozilla-central/rev/930c12a120ab
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.