1244160 - Create json-schema for build telemetry data

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Dan Minor [:dminor]]

The telemetry team has asked for a json schema for data we'll be submitting to telemetry.

My impression is that this is to protect themselves from bad data in their "pipeline". Since we're not asking them to do any processing at this point, I'm going to create a minimalist schema for now.

We can lock things done further once we've done some iterations on what we're going to be reporting and especially in the case we get them to do more processing on what is being submitted.

Comment 1

[Dan Minor [:dminor]]

Attachment: MozReview Request: Bug 1244160 - Create json-schema for build telemetry data r?gps

This adds a simple schema for build telemetry data. We can make it more
restrictive once we have a better feeling for what kind of data we want
to submit.

This also moves more common data about the system to the telemetry handler.
We leave psutil derivied information in the resource usage data as not every
system will have psutil installed.

Review commit: https://reviewboard.mozilla.org/r/35145/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35145/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8719865 [details]
MozReview Request: Bug 1244160 - Create json-schema for build telemetry data r?gps

https://reviewboard.mozilla.org/r/35145/#review31737

::: python/mozbuild/mozbuild/resources/html-build-viewer/index.html:59
(Diff revision 1)
> -  if (data.version != 1 && data.version != 2) {
> +  if (data.version != 1 && data.version != 2 && data.version != 3) {

Might as well use <= and >=.

Comment 3

[Rob Miller [:rmiller]]

LGTM

Comment 4

[Rob Miller [:rmiller]]

Comment on attachment 8719865 [details]
MozReview Request: Bug 1244160 - Create json-schema for build telemetry data r?gps

LGTM

Comment 5

[Dan Minor [:dminor]]

Comment on attachment 8719865 [details]
MozReview Request: Bug 1244160 - Create json-schema for build telemetry data r?gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35145/diff/1-2/

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/930c12a120ab

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/930c12a120ab