All users were logged out of Bugzilla on October 13th, 2018

icons lost in the folder picker

RESOLVED FIXED in Thunderbird 47.0

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: aceman, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 47.0
x86
Linux

Thunderbird Tracking Flags

(thunderbird45 fixed, thunderbird46 fixed, thunderbird47 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
I noticed in recent nightlies of TB that the icons in the folder picker widget are all lost (on linux Gtk3). When the picker is collapsed the current folder is shown with an icon. But when the picker is opened (dropdown), none of the items has any icon.

In last nightly of Windows XP, the icons are there. So this may be only a problem with Linux theme.
(Assignee)

Comment 1

3 years ago
I'm seeing this too when I disable in GTK the show icons in menus setting. When you have disabled it, then you should not see any icons in main menu like on File/Quit.

If it's desired to always show the icons in folder picker I can override this setting in a patch.
(Reporter)

Comment 2

3 years ago
Hi, where is this setting? What program can I run the find these settings? I do not use GTK3 for anything so the only thing using it is FF/TB nightly. I do not think I have set such a setting (as I have no GTK using desktop), unless it is the default.
(Assignee)

Comment 3

3 years ago
Created attachment 8713985 [details]
GTK_icons.png

If I remember correctly you are on Kubuntu or a other distribution with KDE. The the setting can be found in the Setting you can see in the screenshot. The same is for the buttons.
(Assignee)

Comment 4

3 years ago
Created attachment 8714085 [details] [diff] [review]
folderMenuItem.patch

I thought a little bit about this and this icons should always be shown as they help recognizing the correct folder.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8714085 - Flags: review?(acelists)
(Reporter)

Comment 5

3 years ago
(In reply to Richard Marti (:Paenglab) from comment #3)
> Created attachment 8713985 [details]
> GTK_icons.png
> 
> If I remember correctly you are on Kubuntu or a other distribution with KDE.
> The the setting can be found in the Setting you can see in the screenshot.
> The same is for the buttons.

I'm on KDE 3 and I do not have such a setting panel in the Control center. Anyway, I think TB has its own setting for the toolbars whether to display Icons only, text or text+icons. If anything this, setting should be obeyed. But the folder picker is a bit different. E.g. showing Icons only would not make sense.
(Reporter)

Comment 6

3 years ago
Comment on attachment 8714085 [details] [diff] [review]
folderMenuItem.patch

Review of attachment 8714085 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, always show the icons for now and do not blindly obey the gtk3 system setting. On the main TB toolbar we also do not obey it. If anybody wants the icons to be hidden, proper analysis needs to be done on when and what to hide.
Attachment #8714085 - Flags: review?(acelists) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 7

3 years ago
https://hg.mozilla.org/comm-central/rev/63246ba6b8df37d44271c34a3c54305cea6d964e
Bug 1244165 - Show always the folder picker icon in menus. r=aceman

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 47.0
(Assignee)

Comment 8

3 years ago
Comment on attachment 8714085 [details] [diff] [review]
folderMenuItem.patch

[Approval Request Comment]
User impact if declined: no icons on some Linux configurations
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Attachment #8714085 - Flags: approval-comm-beta?
Attachment #8714085 - Flags: approval-comm-aurora?

Updated

3 years ago
Attachment #8714085 - Flags: approval-comm-aurora? → approval-comm-aurora+

Comment 9

3 years ago
Aurora (TB 46):
https://hg.mozilla.org/releases/comm-aurora/rev/b78a55a2bec6
status-thunderbird45: --- → affected
status-thunderbird46: --- → fixed
status-thunderbird47: --- → fixed

Comment 10

3 years ago
Comment on attachment 8714085 [details] [diff] [review]
folderMenuItem.patch

http://hg.mozilla.org/releases/comm-beta/rev/cfd8eb244210
Attachment #8714085 - Flags: approval-comm-beta? → approval-comm-beta+

Updated

3 years ago
status-thunderbird45: affected → fixed
You need to log in before you can comment on or make changes to this bug.