1244165 - icons lost in the folder picker

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[:aceman]

I noticed in recent nightlies of TB that the icons in the folder picker widget are all lost (on linux Gtk3). When the picker is collapsed the current folder is shown with an icon. But when the picker is opened (dropdown), none of the items has any icon.

In last nightly of Windows XP, the icons are there. So this may be only a problem with Linux theme.

Comment 1

[Richard Marti (:Paenglab)]

I'm seeing this too when I disable in GTK the show icons in menus setting. When you have disabled it, then you should not see any icons in main menu like on File/Quit.

If it's desired to always show the icons in folder picker I can override this setting in a patch.

Comment 2

[:aceman]

Hi, where is this setting? What program can I run the find these settings? I do not use GTK3 for anything so the only thing using it is FF/TB nightly. I do not think I have set such a setting (as I have no GTK using desktop), unless it is the default.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: GTK_icons.png

If I remember correctly you are on Kubuntu or a other distribution with KDE. The the setting can be found in the Setting you can see in the screenshot. The same is for the buttons.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: folderMenuItem.patch

I thought a little bit about this and this icons should always be shown as they help recognizing the correct folder.

Comment 5

[:aceman]

(In reply to Richard Marti (:Paenglab) from comment #3)
> Created attachment 8713985 [details]
> GTK_icons.png
> 
> If I remember correctly you are on Kubuntu or a other distribution with KDE.
> The the setting can be found in the Setting you can see in the screenshot.
> The same is for the buttons.

I'm on KDE 3 and I do not have such a setting panel in the Control center. Anyway, I think TB has its own setting for the toolbars whether to display Icons only, text or text+icons. If anything this, setting should be obeyed. But the folder picker is a bit different. E.g. showing Icons only would not make sense.

Comment 6

[:aceman]

Comment on attachment 8714085 [details] [diff] [review]
folderMenuItem.patch

Review of attachment 8714085 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, always show the icons for now and do not blindly obey the gtk3 system setting. On the main TB toolbar we also do not obey it. If anybody wants the icons to be hidden, proper analysis needs to be done on when and what to hide.

Comment 7

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/63246ba6b8df37d44271c34a3c54305cea6d964e
Bug 1244165 - Show always the folder picker icon in menus. r=aceman

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 8714085 [details] [diff] [review]
folderMenuItem.patch

[Approval Request Comment]
User impact if declined: no icons on some Linux configurations
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Jorg K (CEST = GMT+2)]

Aurora (TB 46):
https://hg.mozilla.org/releases/comm-aurora/rev/b78a55a2bec6

Comment 10

[Kent James (:rkent)]

Comment on attachment 8714085 [details] [diff] [review]
folderMenuItem.patch

http://hg.mozilla.org/releases/comm-beta/rev/cfd8eb244210