Closed
Bug 1244182
Opened 8 years ago
Closed 8 years ago
Properly document all the fields of the main ping
Categories
(Toolkit :: Telemetry, defect, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: Dexter, Assigned: Dexter)
References
Details
(Whiteboard: [measurement:client])
Attachments
(1 file, 1 obsolete file)
7.10 KB,
patch
|
Dexter
:
review+
|
Details | Diff | Splinter Review |
We need to properly document all the fields in the main ping.
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
We should at least have a small description for all the top level properties.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → alessio.placitelli
Assignee | ||
Comment 2•8 years ago
|
||
Sorry for the delay, but this took a bit of code archaeology to find out about a few things :)
Attachment #8715741 -
Flags: review?(gfritzsche)
Comment 3•8 years ago
|
||
Comment on attachment 8715741 [details] [diff] [review] bug1244182.patch Review of attachment 8715741 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/telemetry/docs/main-ping.rst @@ +84,5 @@ > If ``sessionLength`` is ``-1``, the monotonic clock is not working. > > +childPayloads > +------------- > +The Telemetry payloads sent by child processes, only available with e10s. Lets add a little bit on the contents of the child payloads (i.e. they are a reduced session payload with ... stripped). I'd like to see more documentation on how they are collected etc. - maybe chutten can document this in a follow-up bug.
Attachment #8715741 -
Flags: review?(gfritzsche) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8715741 -
Attachment is obsolete: true
Attachment #8716936 -
Flags: review+
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Georg Fritzsche [:gfritzsche] from comment #3) > I'd like to see more documentation on how they are collected etc. - maybe > chutten can document this in a follow-up bug. Filed bug 1246644.
Keywords: checkin-needed
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/68f3b136eeac
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•