Add 'ka' to Fennec all-locales for single-locale builds

VERIFIED FIXED in Firefox 46

Status

()

Firefox for Android
General
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: gueroJeff, Assigned: gueroJeff)

Tracking

unspecified
Firefox 46
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8713718 [details] [diff] [review]
add-ka-all.patch

Please add the Georgian (ka) locale to mozilla-aurora/mobile/android/locales/all-locales to start fennec single-locale builds in Aurora and add Fennec to the lo team's dashboard.
Attachment #8713718 - Flags: review?(l10n)
Attachment #8713718 - Flags: approval-mozilla-aurora?

Updated

2 years ago
Attachment #8713718 - Flags: review?(l10n) → review+
Comment on attachment 8713718 [details] [diff] [review]
add-ka-all.patch

Approved for uplift to aurora, adding a locale.
Attachment #8713718 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 2

2 years ago
Thanks Liz!
Whiteboard: checkin-needed-aurora
https://hg.mozilla.org/releases/mozilla-aurora/rev/9fdc25016510
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Whiteboard: checkin-needed-aurora
Target Milestone: --- → Firefox 46
(Assignee)

Comment 4

2 years ago
ka apks aren't appearing in https://ftp.mozilla.org/pub/mobile/nightly/latest-mozilla-aurora-android-api-15-l10n/

Am I looking in the wrong place?
I see them now, probably just a matter of time
https://ftp.mozilla.org/pub/mobile/nightly/latest-mozilla-aurora-android-api-15-l10n/fennec-46.0a2.ak.android-arm.apk
Status: RESOLVED → VERIFIED

Comment 6

2 years ago
(In reply to Francesco Lodolo [:flod] from comment #5)
> I see them now, probably just a matter of time
> https://ftp.mozilla.org/pub/mobile/nightly/latest-mozilla-aurora-android-api-
> 15-l10n/fennec-46.0a2.ak.android-arm.apk

Hey Francesco, thats for Akan language. Georgian language code is ka. It's still not available for download for some reason.
(In reply to Beqa Arabuli from comment #6)
> Hey Francesco, thats for Akan language. Georgian language code is ka. It's
> still not available for download for some reason.

Argh, I blame the lack of coffee for that.

I see 3 errors in compare-locales, I'm pretty sure without fixing those the build won't succeed
https://l10n.mozilla.org/dashboard/compare?run=570387

mobile/android/base
android_strings.dtd
not well-formed (invalid token) at line 717, column 56 for remote_tabs_last_synced
Quotes in Android DTDs need escaping with \" or \u0022, or put string in apostrophes. at line 272, column 42 for tab_queue_notification_settings
Quotes in Android DTDs need escaping with \" or \u0022, or put string in apostrophes. at line 272, column 67 for tab_queue_notification_settings
sync_strings.dtd
not well-formed (invalid token) at line 228, column 52 for fxaccount_remove_account_dialog_message

But I'm also having issues understanding these errors compared to the source files. Will try to look into it later.

Comment 8

2 years ago
Ok, I found those errors and think I fixed them.
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ka/file/f2984e0e3ef7/mobile/android/base/android_strings.dtd#l272
The two " need to become \" (that's a bug in the en-US source that should be fixed soon, bug 1244241).

http://hg.mozilla.org/releases/l10n/mozilla-aurora/ka/file/f2984e0e3ef7/mobile/android/base/sync_strings.dtd#l229

There should not be a %S but a &brandShortName; at the beginning
https://transvision.mozfr.org/?recherche=fxaccount_remove_account_dialog_message&repo=aurora&sourcelocale=en-US&locale=ka&search_type=strings_entities
Assignee: nobody → jbeatty

Comment 10

2 years ago
They are all fixed on Pontoon now.(In reply to Francesco Lodolo [:flod] from comment #9)
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/ka/file/f2984e0e3ef7/
> mobile/android/base/android_strings.dtd#l272
> The two " need to become \" (that's a bug in the en-US source that
> should be fixed soon, bug 1244241).
> 
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/ka/file/f2984e0e3ef7/
> mobile/android/base/sync_strings.dtd#l229
> 
> There should not be a %S but a &brandShortName; at the beginning
> https://transvision.mozfr.org/
> ?recherche=fxaccount_remove_account_dialog_message&repo=aurora&sourcelocale=e
> n-US&locale=ka&search_type=strings_entities

They are all fixed on Pontoon now.
(Assignee)

Comment 11

2 years ago
I forget how fickle Android builds can be. Thanks for fixing those, Beqa. We'll need to check-in tomorrow at https://ftp.mozilla.org/pub/mobile/nightly/latest-mozilla-aurora-android-api-15-l10n/ to be sure that these fixes were what caused the build failures.
We have a build, and this time is ka, not ak
https://ftp.mozilla.org/pub/mobile/nightly/latest-mozilla-aurora-android-api-15-l10n/fennec-46.0a2.ka.android-arm.apk

Comment 13

2 years ago
(In reply to Francesco Lodolo [:flod] from comment #12)
> We have a build, and this time is ka, not ak
> https://ftp.mozilla.org/pub/mobile/nightly/latest-mozilla-aurora-android-api-
> 15-l10n/fennec-46.0a2.ka.android-arm.apk

Great news! Downloaded and everything's working. Thanks.
You need to log in before you can comment on or make changes to this bug.