1244223 - Unhandled promise rejections in debugger tests

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Bug 1240804 uncovered several debugger tests that fail when unhandled promise rejection tracking is used:

devtools/client/debugger/test/mochitest/browser_dbg_addon-modules.js
devtools/client/debugger/test/mochitest/browser_dbg_addon-panels.js
devtools/client/debugger/test/mochitest/browser_dbg_addon-panels.js
devtools/client/debugger/test/mochitest/browser_dbg_addon-sources.js
devtools/client/debugger/test/mochitest/browser_dbg_addon-sources.js
devtools/client/debugger/test/mochitest/browser_dbg_scripts-switching-03.js
devtools/client/debugger/test/mochitest/browser_dbg_server-conditional-bp-03.js

Please note you need to apply the patch in bug 1240804 to see the test failures.

Comment 1

[James Long (:jlongster)]

Made a few tweaks, let's see if it fixes everything: https://treeherder.mozilla.org/#/jobs?repo=try&revision=57d7278a3691

Comment 2

[James Long (:jlongster)]

Attachment: 1244223.patch

These changes might fix the rests of the tests

Comment 3

[James Long (:jlongster)]

Awesome, I think my changes do fix everything. I'll land fixes for all tests in this bug except for script-switching which I will fix in bug 1244892.

Comment 4

[James Long (:jlongster)]

I feel the need to do a normal try run (without the promise patch) before actually landing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3ac14b5fcd7

Just to make sure I'm not missing something that is actually failing (the above try still has a ton of errors)

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/74e3b33329f5

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/74e3b33329f5