Closed Bug 1244252 Opened 5 years ago Closed 5 years ago

TSan: data race ObjectGroup / TI with generation()

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: terrence, Assigned: bhackett1024)

Details

Attachments

(2 files)

Attached file tsan_objectgroup.txt
I think we probably need to use a non-generation-checking version when running OMT here.
Flags: needinfo?(bhackett1024)
Attached patch patchSplinter Review
Yes, that would be better.  This is actually OK as is, since during IonBuilder we'll inspect the ObjectGroup and sweep it if needed, but that isn't something that can be relied on.
Assignee: nobody → bhackett1024
Flags: needinfo?(bhackett1024)
Attachment #8724599 - Flags: review?(terrence)
Comment on attachment 8724599 [details] [diff] [review]
patch

Review of attachment 8724599 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8724599 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/7d0c95cfa2e0
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.