Closed Bug 1244268 Opened 4 years ago Closed 4 years ago

JSON Viewer: remove headers tab expand / collapse buttons

Categories

(DevTools :: JSON Viewer, defect)

defect
Not set

Tracking

(firefox49 fixed)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox49 --- fixed

People

(Reporter: clarkbw, Assigned: davidwalsh)

References

Details

Attachments

(1 file, 1 obsolete file)

via bug 1223143 comment 7

> - In the Headers tab, the headings have a [-] icon but can’t be collapsed
> (not that collapsing would be that useful here).

We should just hide the collapse buttons, there is plenty of room to see the headers and the page scrolls otherwise.
Blocks: 1243951
Attachment #8741944 - Flags: review?(odvarko)
Comment on attachment 8741944 [details]
MozReview Request: Bug 1244268 - Remove expand/collapse headings in JSONView Headers tab

https://reviewboard.mozilla.org/r/46863/#review43675

Nice!

Please resolve my comment and I'll r+ this.

We also need a try push for the patch.

Honza

::: devtools/client/jsonview/css/headers-panel.css
(Diff revision 1)
>    color: #565656;
> -}
> -
> -.headersPanelBox .netHeader.twisty {
> -  background-image: url(twisty-open.svg);
> -  background-repeat: no-repeat;

Please remove also twisty-open.svg and twisty.close.svg files - it isn't used anymore.

Honza
Attachment #8741944 - Flags: review?(odvarko)
Comment on attachment 8741944 [details]
MozReview Request: Bug 1244268 - Remove expand/collapse headings in JSONView Headers tab

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46863/diff/1-2/
Attachment #8741944 - Attachment description: MozReview Request: Bug 1244268 - Remove collapse / expand from JSON Viewer's Header tab → MozReview Request: Bug 1244268 - Remove images no longer used by JSON Viewer
Comment on attachment 8741944 [details]
MozReview Request: Bug 1244268 - Remove expand/collapse headings in JSONView Headers tab

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46863/diff/2-3/
Attachment #8741944 - Attachment description: MozReview Request: Bug 1244268 - Remove images no longer used by JSON Viewer → MozReview Request: Bug 1244268 - Remove CSS for expand/collapse headings in JSONView Headers tab
Comment on attachment 8741944 [details]
MozReview Request: Bug 1244268 - Remove expand/collapse headings in JSONView Headers tab

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46863/diff/3-4/
Attachment #8741944 - Attachment description: MozReview Request: Bug 1244268 - Remove CSS for expand/collapse headings in JSONView Headers tab → MozReview Request: Bug 1244268 - Remove expand/collapse headings in JSONView Headers tab
Flags: needinfo?(odvarko)
Comment on attachment 8741944 [details]
MozReview Request: Bug 1244268 - Remove expand/collapse headings in JSONView Headers tab

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46863/diff/4-5/
Attachment #8741944 - Attachment description: MozReview Request: Bug 1244268 - Remove expand/collapse headings in JSONView Headers tab → MozReview Request: Bug 1244268 - Remove expand/collapse headings in JSONView Headers tab
Updated again, sorry! Should be set now!
Comment on attachment 8741944 [details]
MozReview Request: Bug 1244268 - Remove expand/collapse headings in JSONView Headers tab

https://reviewboard.mozilla.org/r/46863/#review43745

Looks good!

Honza
Flags: needinfo?(odvarko)
https://reviewboard.mozilla.org/r/46863/#review43745

In looking at the `devtools/client/jsonview/css/moz.build` file, I still see mention of `twisty-closed.svg` and `twist-open.svg`; I presume I missed that and the `moz.build` file must also be updated?
Flags: needinfo?(odvarko)
(In reply to David Walsh :davidwalsh from comment #10)
> https://reviewboard.mozilla.org/r/46863/#review43745
> 
> In looking at the `devtools/client/jsonview/css/moz.build` file, I still see
> mention of `twisty-closed.svg` and `twist-open.svg`; I presume I missed that
> and the `moz.build` file must also be updated?
Ah, yes, both files need to be removed.

Honza
Flags: needinfo?(odvarko)
Comment on attachment 8741944 [details]
MozReview Request: Bug 1244268 - Remove expand/collapse headings in JSONView Headers tab

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46863/diff/5-6/
Keywords: checkin-needed
sorry had to back this out in  https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=f0210b36ff71 since of this patches caused a bustage like :

https://hg.mozilla.org/integration/fx-team/rev/ee2fff382352d57eeb2c7b5ae35c8eaa254e486e

seems the error is ==============================
 05:54:52     INFO -  The error occurred while processing the following file or one of the files it includes:
 05:54:52     INFO -      /builds/slave/fx-team-m64-000000000000000000/build/src/devtools/client/jsonview/css/moz.build
 05:54:52     INFO -  The error occurred when validating the result of the execution. The reported error is:
 05:54:52     INFO -      File listed in FINAL_TARGET_FILES does not exist: /builds/slave/fx-team-m64-000000000000000000/build/src/devtools/client/jsonview/css/twisty-closed.svg
 05:54:52     INFO -  *** Fix above errors and then restart with               "/usr/bin/make -f client.mk build"
05:54:52 INFO - make[3]: *** [conf
Flags: needinfo?(dwalsh)
Excuse my DevTools+Mercurial workflow noobage but my commit removes said files here:

https://reviewboard.mozilla.org/r/46863/diff/6#2

:Honza : What would cause this build failure?  How would I have not seen this before (is it because I did `./mach build faster` ?
Flags: needinfo?(odvarko)
Flags: needinfo?(dwalsh)
Flags: needinfo?(cbook)
Solved on IRC, looks like a bug in Reviewboard resulting in a wrong commit. Btw. there are similar bug reports for Reviewboard already: https://bugzilla.mozilla.org/showdependencytree.cgi?id=1255654&hide_resolved=1

Honza
Flags: needinfo?(odvarko)
Attachment #8741944 - Attachment is obsolete: true
Attachment #8745412 - Flags: review?(odvarko)
Flags: needinfo?(cbook)
Comment on attachment 8745412 [details]
MozReview Request: Bug 1244268 - Remove expand/collapse headings in JSONView Headers tab

https://reviewboard.mozilla.org/r/49031/#review46081
Attachment #8745412 - Flags: review?(odvarko) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/037f55023728
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Assignee: nobody → dwalsh
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.