1244357 - Shim the certificate database in xpcshell tests

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

The xpcshell tests generate and modify a lot of add-ons on the fly. When signing becomes mandatory they will suddenly all fail to work unless we also sign them. But switching from generated extensions to in-tree ones would be a lot of work  even ignoring getting them signed.

In xpcshell tests though we have the ability to shim certain xpcom components and the certificate database we use to verify XPI signatures is one of them. This can't work for the other test suites because it has already been loaded by the time the test harness runs.

With this approach we can effectively force the add-ons manager to believe that add-ons are signed even though they have no signature.

Comment 1

[Dave Townsend [:mossop]]

Attachment: MozReview Request: Bug 1244357: Use a shim around the certificate DB to allow the add-ons manager to think that add-ons are signed when they aren't. r=rhelmer

Review commit: https://reviewboard.mozilla.org/r/33101/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33101/

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8714474 [details]
MozReview Request: Bug 1244357: Use a shim around the certificate DB to allow the add-ons manager to think that add-ons are signed when they aren't. r=rhelmer

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33101/diff/1-2/

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8714474 [details]
MozReview Request: Bug 1244357: Use a shim around the certificate DB to allow the add-ons manager to think that add-ons are signed when they aren't. r=rhelmer

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33101/diff/2-3/

Comment 4

[Robert Helmer [:rhelmer]]

Comment on attachment 8714474 [details]
MozReview Request: Bug 1244357: Use a shim around the certificate DB to allow the add-ons manager to think that add-ons are signed when they aren't. r=rhelmer

https://reviewboard.mozilla.org/r/33101/#review30473

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c57d2020f884

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c882b4072883

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 8714474 [details]
MozReview Request: Bug 1244357: Use a shim around the certificate DB to allow the add-ons manager to think that add-ons are signed when they aren't. r=rhelmer

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33101/diff/3-4/

Comment 8

[Dave Townsend [:mossop]]

Comment on attachment 8714474 [details]
MozReview Request: Bug 1244357: Use a shim around the certificate DB to allow the add-ons manager to think that add-ons are signed when they aren't. r=rhelmer

Can't figure out how to re-request review in review board. Can you skim over the last interdiff, it just makes the cache flush test ignore flushes from the fake certificate db.

Comment 9

[Robert Helmer [:rhelmer]]

Comment on attachment 8714474 [details]
MozReview Request: Bug 1244357: Use a shim around the certificate DB to allow the add-ons manager to think that add-ons are signed when they aren't. r=rhelmer

https://reviewboard.mozilla.org/r/33101/#review30873

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1d5b210de3c9

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1d5b210de3c9

Comment 12

[Dave Townsend [:mossop]]

Comment on attachment 8714474 [details]
MozReview Request: Bug 1244357: Use a shim around the certificate DB to allow the add-ons manager to think that add-ons are signed when they aren't. r=rhelmer

Approval Request Comment
[Feature/regressing bug #]: Signed add-ons
[User impact if declined]: This is needed to force signing on in 46
[Describe test coverage new/current, TreeHerder]: On m-c for a while
[Risks and why]: Very low, mostly test only changes
[String/UUID change made/needed]: None

Comment 13

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8714474 [details]
MozReview Request: Bug 1244357: Use a shim around the certificate DB to allow the add-ons manager to think that add-ons are signed when they aren't. r=rhelmer

We want our tests to work for sure. Approved for uplift to aurora.

Comment 14

[Dave Townsend [:mossop]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4a6c83a841c7