Closed
Bug 1244358
Opened 9 years ago
Closed 9 years ago
Support all types in PersistentRooted
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
15.21 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Now that RootKind is well defined, we can refactor PersistentRooted to look more like Rooted. This lets us do more with less. Much less, actually: 6 files changed, 64 insertions(+), 152 deletions(-) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7319fd2c35bd
Attachment #8713897 -
Flags: review?(sphink)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8713897 [details] [diff] [review] 2.2_support_all_types_in_PersistentRooted-v0.diff Review of attachment 8713897 [details] [diff] [review]: ----------------------------------------------------------------- lgtm. It's great to see these commoned up.
Attachment #8713897 -
Flags: review?(sphink) → review+
|
Assignee | |
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee852e6779fb62f910f6941f50d60d69f36849ae Bug 1244358 - Support all types in PersistentRooted; r=sfink
|
||
Comment 3•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ee852e6779fb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•