Closed Bug 1244367 Opened 10 years ago Closed 10 years ago

Compare against another revision doesn't work as expected from treeherder job view

Categories

(Tree Management :: Perfherder, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wlach, Assigned: wlach)

Details

Attachments

(1 file)

Load this for example on stage: https://treeherder.allizom.org/#/jobs?repo=try&revision=d00e579c9a88&selectedJob=16674237 Two problems: 1. It links to a compare chooser on production, rather than stage 2. There is no revision in the link when you first load the job/panel. i.e. it links to something like: https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision= (if you select another job and then come back to this one, then it gets filled in) The first is easy to fix, not sure about the second.
Attachment #8713906 - Flags: review?(jmaher)
Comment on attachment 8713906 [details] [review] [treeherder] wlach:1244367 > mozilla:master so simple
Attachment #8713906 - Flags: review?(jmaher) → review+
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/d0a4b50511e30bc24de819e7a024f9dba762cb7c Bug 1244367 - Link to perfherder compare shouldn't always be against treeherder prod https://github.com/mozilla/treeherder/commit/9c27e3be30074eba7f36c4c755200c74931c1ad0 Merge pull request #1287 from wlach/1244367 Bug 1244367 - Link to perfherder compare shouldn't always be against treeherder prod
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee: nobody → wlachance
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: