124438 - [modern] MailNews Get Msgs icon missing shadow in modern theme

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[WD]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.8+)
Gecko/20020208
BuildID:    2002020803

All the icons in MailNews have shadows.  But the Get Msgs icon only has a
shadown when hovered over

Reproducible: Always
Steps to Reproduce:
1.move mouse over all icons in mailnews  (in a state where Get Msgs is "active",
such as in a newsgroup or your inbox)
2.
3.

Actual Results:  Get Msgs only has a shadow when hovered over

Expected Results:  The shadow is always there

Comment 1

[R.K.Aa.]

*** Bug 126403 has been marked as a duplicate of this bug. ***

Comment 2

[marlon bishop]

 shuehan, when you get a chance, can you check in getmsg.gif?  just re-export it
from ice_small_button_gen6(RTM)s.psd, it should be fixed now.

Comment 3

[Stefan Borggraefe]

Attachment: Messenger buttons with the corrected GetMsgs button

Made up a corrected version of themes/modern/messenger/icons/btn1.gif. I hope
this is the correct way to fix this.

Stefan

Comment 4

[marlon bishop]

Attachment: original getmsg button as it should have been

there was a layer scripted to turn off in my imageready file. fixed it.

Comment 5

[Stefan Borggraefe]

marlon: I just tried to combine the button-image you posted with btn1.gif, but
surprisingly there are two problems:

1. The image you posted is two pixels to narrow.
2. The dithering of the image seems to be of much higher quality than the
dithering of all other buttons in btn1.gif.

Stefan

Comment 6

[marlon bishop]

hi stefan, for 1) this is probably because when we went to the composited button
map instead of using individual files, the engineers may have done something to
make the button fit.  The one i attached is how it would have been before we
started using the btn1 map.  2) The reason the dither quality is so much better
is that my single image has all 256 color slots devoted just one icon.  Where
the btn1.gif, has forced the wide gamut of colors used in buttons into just 256
colors.  This in my opinion was an atrocious side effect of going to the new
theme implementation.  I would have liked us to have gone with PNG-8 since it
would have kept modern buttons at their highest bit depth, and at full brilliance. 

Comment 7

[Adam Becevello]

Attachment: updated btn1.gif

Since this bug has been inactive since 2002-08-14, I decided to help out.
Here's an updated version of btn1.gif for modern.

Comment 8

[Adam Becevello]

Comment on attachment 118604 [details]
updated btn1.gif

This image fixes a missing shadow under the Get Msgs button in MailNews.

Comment 9

[Adam Becevello]

Comment on attachment 118604 [details]
updated btn1.gif

Requesting review of this image which fixes a missing shadow under the Get Msgs
button in MailNews.

Comment 10

[marlon bishop]

looks good.  thank you

Comment 11

[(not reading, please use [e-mail] instead)]

over to adam.  I'll test and check it in.

Comment 12

[(not reading, please use [e-mail] instead)]

Comment on attachment 118604 [details]
updated btn1.gif

sr=sspitzer

checked it in, r=marlon.

Comment 13

[(not reading, please use [e-mail] instead)]

fixed

Comment 14

[Peter Lairo]

Regression? When i depress the "get Msgs" (and the "Print") button, the text
below the icon doesn't turn white like it does for all the other buttons. :-\

REOPEN? Another bug?

Comment 15

[Adam Becevello]

The text does turn white when you click on the little arrow to get the pop-out
menu.  Its just when you click the actual button that this happens.

From my own testing, it seems that this has always been the case (at least back
as far as 1.0).

Comment 16

[Peter Lairo]

(OT) It seems to me it should also turn white when depressing the main button.

Comment 17

[Adam Becevello]

I believe that as well.  

FYI: The mark button also shows this.  That means that toolbar buttons that have
menus are the problem.

I'm currently trying to find out what isn't working right.  I believe this
should be in another bug.

Comment 18

[Stefan Borggraefe]

Peter, Adam: That´s bug 137020.

I´m verifying this bug because the shadow is now there.