Open Bug 1244409 Opened 7 years ago Updated 5 months ago

Intermittent test_WorkerDebuggerManager.xhtml,test_WorkerDebuggerManager.xhtml| Test timed out

Categories

(Core :: DOM: Workers, defect, P3)

Product:
Core
Component:
DOM: Workers
Type:
defect

Tracking

()

Status:
REOPENED
Tracking Flags:
Tracking Status
firefox47 --- wontfix
firefox48 --- wontfix
firefox49 --- wontfix
firefox50 --- wontfix
firefox51 --- wontfix
firefox52 --- disabled
firefox53 --- disabled
firefox65 --- affected

People

(Reporter: philor, Unassigned)

References

Details

(Keywords: intermittent-failure, regression, Whiteboard: [stockwell unknown])

Attachments

(1 file)

Bug 1244409 - Re-enable DOM worker debugger tests on linux.
47 bytes, text/x-phabricator-request
Details | Review 
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Any idea what might be going on here, Eddy?
status-firefox47: affected → wontfix
status-firefox48: --- → wontfix
status-firefox49: --- → affected
status-firefox50: --- → affected
status-firefox51: --- → affected
Flags: needinfo?(ejpbruel)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #31)
> Any idea what might be going on here, Eddy?

I'd love to help, but the link in comment 1 has expired, so I don't have anything to go on at the moment. Ryan, can you help there?
Flags: needinfo?(ejpbruel) → needinfo?(ryanvm)
Look at any of the recent OrangeFactor robot comments in this bug for a link to newer logs.
Flags: needinfo?(ryanvm) → needinfo?(ejpbruel)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #33)
> Look at any of the recent OrangeFactor robot comments in this bug for a link
> to newer logs.

Doh. I didn't realise I could expand those. They looked like they were empty to me X-D.
Looking at some of the failure logs, we seem to be hanging on shutdown. Could be a race condition where we're racing between waiting for the workers to close and the workers actually closing.
Flags: needinfo?(ejpbruel)
ni? myself to disable since nobody has cycles to investigate.
status-firefox49: affected → wontfix
status-firefox52: --- → affected
Flags: needinfo?(ryanvm)
Different regression window, but I wonder if this and bug 1297267 are at all related.
Flags: needinfo?(ryanvm) → needinfo?(amarchesini)
See Also: → 1244697
status-firefox50: affected → wontfix
status-firefox53: --- → affected
Flags: needinfo?(ryanvm)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8442d968109
Skip test_WorkerDebuggerManager.xul on Linux for intermittent timeouts.
https://hg.mozilla.org/releases/mozilla-aurora/rev/be00bf1f7afa
status-firefox51: affected → wontfix
status-firefox52: affected → disabled
status-firefox53: affected → disabled
Flags: needinfo?(ryanvm)
Flags: needinfo?(amarchesini)
Keywords: leave-open
Whiteboard: [test disabled on Linux]
Priority: P3 → P5
The leave-open keyword is there and there is no activity for 6 months.
:overholt, maybe it's time to close this bug?
Flags: needinfo?(overholt)
I wonder if Yulia or Alex have any thoughts on what should be done here.
Flags: needinfo?(ystartsev)
Flags: needinfo?(poirot.alex)
Flags: needinfo?(overholt)
These tests have been disabled two years ago...
Anything could have happened in the meantime regarding such intermittent.
We may as well re-enable them and have them working as-is!

Here is a try run re-enabling the worker debugger tests on linux to see how they perform today:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=515a3d7ee8d8c701d2a4db51a9a20f395e4ef3a0
Sorry, previous try was broken due to wrong try syntax, here is a valid one.
No intermittent so far with 20 runs, I requested some more:
  https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=214377787&revision=3f231d99f2192861c153b2257bf33e0c0701ed3c
MozReview-Commit-ID: 64TZGSsmE7T
Comment on attachment 9028377 [details]
Bug 1244409 - Re-enable DOM worker debugger tests on linux.

I requested even more runs, but they look pretty green.
Jim, I think you are the only one to have looked into DOM worker debugger now that Eddy/Kyle left...
Flags: needinfo?(ystartsev)
Flags: needinfo?(poirot.alex)
Assignee: nobody → poirot.alex
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c35837cdc103
Re-enable DOM worker debugger tests on linux. r=jimb
I wasn't able to get any failure on try, so I pushed the patch.
But do not hesitate to reopen if they are still intermittent.
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox65: --- → fixed
Keywords: leave-open
Resolution: --- → FIXED
Whiteboard: [test disabled on Linux]
Target Milestone: --- → mozilla65
New occurrences: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=215144965&repo=autoland&lineNumber=19703
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
See Also: → 1454935

There are 41 total failures in the last 7 days on linux-qr and linux-pgo-qr

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=229968476&repo=autoland&lineNumber=5736

[task 2019-02-22T20:13:10.995Z] 20:13:10 INFO - TEST-START | dom/workers/test/test_WorkerDebuggerManager.xul
[task 2019-02-22T20:13:11.035Z] 20:13:11 INFO - GECKO(7351) | FAK WorkerDebuggerManager_worker.js
[task 2019-02-22T20:13:11.038Z] 20:13:11 INFO - GECKO(7351) | FAK WorkerDebuggerManager_worker.js
[task 2019-02-22T20:13:11.066Z] 20:13:11 INFO - GECKO(7351) | FAK WorkerDebuggerManager_childWorker.js
[task 2019-02-22T20:18:23.757Z] 20:18:23 INFO - TEST-INFO | started process screentopng
[task 2019-02-22T20:18:24.056Z] 20:18:24 INFO - TEST-INFO | screentopng: exit 0
[task 2019-02-22T20:18:24.057Z] 20:18:24 INFO - Buffered messages logged at 20:13:11
[task 2019-02-22T20:18:24.058Z] 20:18:24 INFO - Check that worker debuggers are not enumerated before they are registered.
[task 2019-02-22T20:18:24.058Z] 20:18:24 INFO - TEST-PASS | dom/workers/test/test_WorkerDebuggerManager.xul | Worker debugger should not be enumerated before it is registered.
[task 2019-02-22T20:18:24.059Z] 20:18:24 INFO - TEST-PASS | dom/workers/test/test_WorkerDebuggerManager.xul | Child worker debugger should not be enumerated before it is registered.
[task 2019-02-22T20:18:24.060Z] 20:18:24 INFO - Create a worker that creates a child worker, and wait for their debuggers to be registered.
[task 2019-02-22T20:18:24.060Z] 20:18:24 INFO - TEST-PASS | dom/workers/test/test_WorkerDebuggerManager.xul | Debugger with url WorkerDebuggerManager_worker.js should be registered.
[task 2019-02-22T20:18:24.060Z] 20:18:24 INFO - TEST-PASS | dom/workers/test/test_WorkerDebuggerManager.xul | Promise 1 out of 2 should be resolved.
[task 2019-02-22T20:18:24.061Z] 20:18:24 INFO - TEST-PASS | dom/workers/test/test_WorkerDebuggerManager.xul | Debugger with url WorkerDebuggerManager_childWorker.js should be registered.
[task 2019-02-22T20:18:24.062Z] 20:18:24 INFO - TEST-PASS | dom/workers/test/test_WorkerDebuggerManager.xul | Promise 2 out of 2 should be resolved.
[task 2019-02-22T20:18:24.063Z] 20:18:24 INFO - Check that worker debuggers are enumerated after they are registered.
[task 2019-02-22T20:18:24.065Z] 20:18:24 INFO - TEST-PASS | dom/workers/test/test_WorkerDebuggerManager.xul | Worker debugger should be enumerated after it is registered.
[task 2019-02-22T20:18:24.065Z] 20:18:24 INFO - TEST-PASS | dom/workers/test/test_WorkerDebuggerManager.xul | Child worker debugger should be enumerated after it is registered.
[task 2019-02-22T20:18:24.066Z] 20:18:24 INFO - Check that worker debuggers are not closed before they are unregistered.
[task 2019-02-22T20:18:24.067Z] 20:18:24 INFO - TEST-PASS | dom/workers/test/test_WorkerDebuggerManager.xul | Worker debugger should not be closed before it is unregistered.
[task 2019-02-22T20:18:24.069Z] 20:18:24 INFO - TEST-PASS | dom/workers/test/test_WorkerDebuggerManager.xul | Child worker debugger should not be closed before it is unregistered
[task 2019-02-22T20:18:24.069Z] 20:18:24 INFO - Terminate the worker and the child worker, and wait for their debuggers to be unregistered.
[task 2019-02-22T20:18:24.069Z] 20:18:24 INFO - Buffered messages finished
[task 2019-02-22T20:18:24.069Z] 20:18:24 INFO - TEST-UNEXPECTED-FAIL | dom/workers/test/test_WorkerDebuggerManager.xul | Test timed out.
[task 2019-02-22T20:18:24.069Z] 20:18:24 INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:275:18
[task 2019-02-22T20:18:24.069Z] 20:18:24 INFO - reportError@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:121:22
[task 2019-02-22T20:18:24.069Z] 20:18:24 INFO - TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:142:7
[task 2019-02-22T20:18:24.069Z] 20:18:24 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
[task 2019-02-22T20:18:24.069Z] 20:18:24 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
[task 2019-02-22T20:18:24.069Z] 20:18:24 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
[task 2019-02-22T20:18:24.069Z] 20:18:24 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
[task 2019-02-22T20:18:24.069Z] 20:18:24 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
[task 2019-02-22T20:18:24.069Z] 20:18:24 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
[task 2019-02-22T20:18:24.069Z] 20:18:24 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
[task 2019-02-22T20:18:24.069Z] 20:18:24 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
[task 2019-02-22T20:18:24.069Z] 20:18:24 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
[task 2019-02-22T20:18:24.070Z] 20:18:24 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
[task 2019-02-22T20:18:24.070Z] 20:18:24 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
[task 2019-02-22T20:18:24.070Z] 20:18:24 INFO - TestRunner.runTests/<@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:381:20
[task 2019-02-22T20:18:24.070Z] 20:18:24 INFO - promise callbackTestRunner.runTests@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:368:50
[task 2019-02-22T20:18:24.070Z] 20:18:24 INFO - RunSet.runtests@chrome://mochikit/content/tests/SimpleTest/setup.js:201:14
[task 2019-02-22T20:18:24.070Z] 20:18:24 INFO - RunSet.runall@chrome://mochikit/content/tests/SimpleTest/setup.js:180:12
[task 2019-02-22T20:18:24.070Z] 20:18:24 INFO - hookupTests@chrome://mochikit/content/tests/SimpleTest/setup.js:273:12
[task 2019-02-22T20:18:24.070Z] 20:18:24 INFO - parseTestManifest@chrome://mochikit/content/manifestLibrary.js:38:5
[task 2019-02-22T20:18:24.070Z] 20:18:24 INFO - getTestManifest/req.onload@chrome://mochikit/content/manifestLibrary.js:49:11
[task 2019-02-22T20:18:24.070Z] 20:18:24 INFO - EventHandlerNonNullgetTestManifest@chrome://mochikit/content/manifestLibrary.js:45:3
[task 2019-02-22T20:18:24.070Z] 20:18:24 INFO - hookup@chrome://mochikit/content/tests/SimpleTest/setup.js:253:5
[task 2019-02-22T20:18:24.070Z] 20:18:24 INFO - linkAndHookup@chrome://mochikit/content/harness.xul:54:3
[task 2019-02-22T20:18:24.070Z] 20:18:24 INFO - parseTestManifest@chrome://mochikit/content/manifestLibrary.js:38:5
[task 2019-02-22T20:18:24.070Z] 20:18:24 INFO - getTestManifest/req.onload@chrome://mochikit/content/manifestLibrary.js:49:11
[task 2019-02-22T20:18:24.070Z] 20:18:24 INFO - EventHandlerNonNullgetTestManifest@chrome://mochikit/content/manifestLibrary.js:45:3
[task 2019-02-22T20:18:24.070Z] 20:18:24 INFO - getTestList@chrome://mochikit/content/chrome-harness.js:251:3
[task 2019-02-22T20:18:24.070Z] 20:18:24 INFO - loadTests@chrome://mochikit/content/harness.xul:33:3
[task 2019-02-22T20:18:24.070Z] 20:18:24 INFO - EventListener.handleEvent*@chrome://mochikit/content/harness.xul:57:12
[task 2019-02-22T20:18:24.756Z] 20:18:24 INFO - GECKO(7351) | MEMORY STAT | vsize 2005MB | residentFast 317MB | heapAllocated 101MB
[task 2019-02-22T20:18:24.761Z] 20:18:24 INFO - TEST-OK | dom/workers/test/test_WorkerDebuggerManager.xul | took 313766ms

Julian are you working on this too?

Whiteboard: [stockwell needswork:owner]

Julian are you working on this too?

Not really, that would rather be for :Honza's team although I don't think anybody really owns WorkerDebuggerManager.js? Maybe :loganfsmyth.

For info I am proposing to skip this test on QR platforms in bug 1454935. But since this bug was reopened before the intermittent started spiking on QR platforms, I think we can keep this bug open. Skipping this test on QR platform should makes it less noisy.

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression
Summary: Intermittent test_WorkerDebuggerManager.xul | Test timed out → Intermittent test_WorkerDebuggerManager.xhtml,test_WorkerDebuggerManager.xul | Test timed out
Assignee: poirot.alex → nobody
Priority: -- → P3
Target Milestone: mozilla65 → ---
Summary: Intermittent test_WorkerDebuggerManager.xhtml,test_WorkerDebuggerManager.xul | Test timed out → Intermittent test_WorkerDebuggerManager.xhtml,test_WorkerDebuggerManager.xhtml| Test timed out
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.