1244422 - context menu "Delete This Page" and "Forget About This Site" should not appear on livemark child

Status: RESOLVED WONTFIX

(Toolkit :: Data Sanitization, defect)

Description

[atlanto]

Current behaviour
 Delete This Page: disabled/grayed
 Forget About This Site: enabled but not functional (see bug 1003850)

"Delete This Page" cannot work on livemark child, has no meanings to be appeared, IMO.

"Forget About This Site" doesn't work because browser/components/places/content/controller.js#isCommandEnabled returns false in this case(same as "Delete This Page"). Maybe it is enabled by wrong at controller.js#goUpdatePlacesCommands. (there is no 'updatePlacesCommand("placesCmd_deleteDataHost");')
I don't think having this menu is reasonable, since livemark child is not a history.

These menus are hidden against bookmark.
browser/components/places/content/placesOverlay.xul#201,#210
> forcehideselection="bookmark"/>
It should be "bookmark|livemarkChild", I guess.
And browser/components/places/content/controller.js#_buildSelectionMetadata must be corrected.
>457           if (PlacesUtils.nodeIsBookmark(node)) {
>458             nodeData["bookmark"] = true;
>459             PlacesUtils.nodeIsTagQuery(node.parent)
>460 
>461             var parentNode = node.parent;
>462             if (parentNode) {
>463               if (PlacesUtils.nodeIsTagQuery(parentNode))
>464                 nodeData["tagChild"] = true;
>465               else if (this.hasCachedLivemarkInfo(parentNode))
>466                 nodeData["livemarkChild"] = true;
>467             }
>468           }
Since livemark child is not a bookmark, #466 cannot be reached.

Comment 1

[Marco Bonardo [:mak]]

Wontfixing because live bookmarks are going away - See Bug 1477667.