Closed Bug 1244454 Opened 4 years ago Closed 4 years ago

Fix skia compilation on mingw.

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: jacek, Assigned: jacek)

References

Details

Attachments

(1 file)

Attached patch fixSplinter Review
Problems introduced by upsteram import in bug 1082598, already fixed in Skia:
https://codereview.chromium.org/1589933002/
Attachment #8714001 - Flags: review?(jmuizelaar)
Comment on attachment 8714001 [details] [diff] [review]
fix

Skia reviews should go through Lee.

As an aside has there been any talk within wine of switching to clang to get a front-end that's more compatible with MSVC?
Attachment #8714001 - Flags: review?(jmuizelaar) → review?(lsalzman)
Attachment #8714001 - Flags: review?(lsalzman) → review+
Thanks for review.

I plan to take look at building with clang. Unfortunately, we can't use clang+PSDK, because we need to be able to cross compile from Linux (and allow distros to do it themselves). For that, we could use clang+mingw-w64, but this combination is not well supported yet. There is work in progress on that, so I hope it will be usable soon.
https://hg.mozilla.org/mozilla-central/rev/650c2be3cbf3
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.