1244489 - Intermittent test_LoadedDataFired_mp4.html | must fire playing at start - got 0.816852, expected +0

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P5)

Description

[Phil Ringnalda (:philor)]

https://treeherder.mozilla.org/logviewer.html#?job_id=6936304&repo=fx-team

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1244489: Do not expect currentTime to always be 0 by the time playing is fired.

playing is fired. r?jwwang

The playing event is sent asynchronously. By the time the playing event
actually gets fired, it is possible that playback has already started.

Review commit: https://reviewboard.mozilla.org/r/73746/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73746/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8784206 [details]
Bug 1244489: Do not expect currentTime to always be 0 by the time playing is fired.

https://reviewboard.mozilla.org/r/73746/#review71584

::: dom/media/mediasource/test/test_LoadedDataFired_mp4.html:25
(Diff revision 1)
>      is(el.currentTime, 0, "must fire loadeddata at start");
>    });
>    el.addEventListener("playing", function() {
>      ok(el.buffered.length > 0, "data is buffered");
>      is(el.buffered.start(0), 0, "must fire playing when data has been loaded");
> -    is(el.currentTime, 0, "must fire playing at start");
> +    ok(el.currentTime >= 0, "must fire playing at start");

Change the message to "must have started playback" or something like that.

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8784206 [details]
Bug 1244489: Do not expect currentTime to always be 0 by the time playing is fired.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73746/diff/1-2/

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8784206 [details]
Bug 1244489: Do not expect currentTime to always be 0 by the time playing is fired.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73746/diff/2-3/

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8784206 [details]
Bug 1244489: Do not expect currentTime to always be 0 by the time playing is fired.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73746/diff/3-4/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/687db967e443
Do not expect currentTime to always be 0 by the time playing is fired. r=jwwang

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/687db967e443