1244544 - uiOnlyAllowOneWindow.js mocks nsIDOMWindow/mozIDOMWindowProxy in JS

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

The test mocks the window mediator, and its getMostRecentWindow function.  That used to return an nsIDOMWindow, which was (surprisingly) not 'builtinclass' in the IDL.  The return type has been changed to be mozIDOMWindowProxy which is builtinclass and thus can't be implemented in JS.

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/tests/unit_aus_update/uiOnlyAllowOneWindow.js#71

I disabled this test to land bug 1241764.  I don't know if the test is salvageable.

Comment 1

[Robert Strong (they/them - no direct email)]

Thanks for the heads up.

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1 - remove the test

There are plans in the works to revamp the user interface and this test won't be necessary after that is done so I'm just going to remove it.

I'm going to hold off on this until after bug 394984 and bug 1274487 lands.

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 8754674 [details] [diff] [review]
patch rev1 - remove the test

Note: I'm going to try to hold off on landing this until after spohl's patches land.

Comment 4

[Robert Strong (they/them - no direct email)]

Pushed to try along with bug 1274487
https://treeherder.mozilla.org/#/jobs?repo=try&revision=92bf2f9cd9eb

Comment 5

[Robert Strong (they/them - no direct email)]

Accidentally used the mach syntax... new try push
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ea3cb9d4af2

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/18083cdf9caa

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: patch as landed - had to unbitrot

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/18083cdf9caa