Closed Bug 1244544 Opened 4 years ago Closed 3 years ago

uiOnlyAllowOneWindow.js mocks nsIDOMWindow/mozIDOMWindowProxy in JS

Categories

(Toolkit :: Application Update, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: khuey, Assigned: rstrong)

References

Details

Attachments

(1 file, 1 obsolete file)

The test mocks the window mediator, and its getMostRecentWindow function.  That used to return an nsIDOMWindow, which was (surprisingly) not 'builtinclass' in the IDL.  The return type has been changed to be mozIDOMWindowProxy which is builtinclass and thus can't be implemented in JS.

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/tests/unit_aus_update/uiOnlyAllowOneWindow.js#71

I disabled this test to land bug 1241764.  I don't know if the test is salvageable.
Flags: needinfo?(robert.strong.bugs)
Thanks for the heads up.
Flags: needinfo?(robert.strong.bugs)
Attached patch patch rev1 - remove the test (obsolete) — Splinter Review
There are plans in the works to revamp the user interface and this test won't be necessary after that is done so I'm just going to remove it.

I'm going to hold off on this until after bug 394984 and bug 1274487 lands.
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Comment on attachment 8754674 [details] [diff] [review]
patch rev1 - remove the test

Note: I'm going to try to hold off on landing this until after spohl's patches land.
Attachment #8754674 - Flags: review?(mhowell)
Attachment #8754674 - Flags: review?(mhowell) → review+
https://hg.mozilla.org/mozilla-central/rev/18083cdf9caa
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.