Closed Bug 1244544 Opened 4 years ago Closed 3 years ago
Only Allow One Window .js mocks ns IDOMWindow/moz IDOMWindow Proxy in JS
The test mocks the window mediator, and its getMostRecentWindow function. That used to return an nsIDOMWindow, which was (surprisingly) not 'builtinclass' in the IDL. The return type has been changed to be mozIDOMWindowProxy which is builtinclass and thus can't be implemented in JS. http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/tests/unit_aus_update/uiOnlyAllowOneWindow.js#71 I disabled this test to land bug 1241764. I don't know if the test is salvageable.
Thanks for the heads up.
There are plans in the works to revamp the user interface and this test won't be necessary after that is done so I'm just going to remove it. I'm going to hold off on this until after bug 394984 and bug 1274487 lands.
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Comment on attachment 8754674 [details] [diff] [review] patch rev1 - remove the test Note: I'm going to try to hold off on landing this until after spohl's patches land.
Attachment #8754674 - Flags: review?(mhowell)
Pushed to try along with bug 1274487 https://treeherder.mozilla.org/#/jobs?repo=try&revision=92bf2f9cd9eb
Accidentally used the mach syntax... new try push https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ea3cb9d4af2
Attachment #8754674 - Flags: review?(mhowell) → review+
You need to log in before you can comment on or make changes to this bug.