1244570 - the Folder Location widget on main toolbar is too narrow

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[:aceman]

Attachment: screenshot

Add the "Folder location" widget to the main toolbar.
The widget too narrow. The icon is not centered and even the focus ring does not encompass it but runs underneath the icon. When the widget is in the customize palette, its height is fine (it is higher than when placed on the toolbar).

Comment 1

[Richard Marti (:Paenglab)]

I've also seen this on the no icon bug :) and have a patch ready.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: menulist.patch

This patch gives, like on Windows, menulists on main- and composer toolbars the same appearance as the toolbabutton-1.

Native menulists are taller than the 24px of the toolbabuttons which makes them shrink like on the screenshot. For example one of my Linux themes uses 6px borders and with this the menulist content would only have 12px space which is not enough.

Comment 3

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/13181b2468b97b0c60b00596d997e3f3ed20cdcb
Bug 1244570 - Style the toolar menulists like toolbarbutton-1. r=mkmelin

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 8714382 [details] [diff] [review]
menulist.patch

[Approval Request Comment]
Regression caused by (bug #): 1242261 which has approval c-a and c-b
User impact if declined: too narrow menulist on main toolbar
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Jorg K (CEST = GMT+2)]

Aurora (TB 46):
https://hg.mozilla.org/releases/comm-aurora/rev/71483c515acd

Comment 6

[Kent James (:rkent)]

Comment on attachment 8714382 [details] [diff] [review]
menulist.patch

http://hg.mozilla.org/releases/comm-beta/rev/e1989c919d60

Comment 7

[Kent James (:rkent)]

Richard, the standard for release tracking is that Target Milestone is set for when the patch actually lands, and tracking flags are used for uplifts. Doesn't make a lot of sense, but that is the system.