1244584 - GCLI tooltip doesn't hide completely when I press "Got it!" button (first-run experience)

Status: VERIFIED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P2)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 46, 32bit, ID 20160129030206
STR:
1. Set preference "devtools.gcli.hideIntro" to "false"
2. Make sure that command line is closed
3. Restart the browser
4. Open command line (Shift+F2)
5. Click "Got it!" button in tooltip

AR: All text in tooltip disappears, but not tooltip itself: I can still see a small black rectangle 
ER: Tooltip should disappear completely.

Note:
 Here's the code from resource://devtools/shared/gcli/source/lib/gcli/ui/intro.js:80 :
      onGotIt: function(ev) {
        var settings = conversionContext.system.settings;
        var hideIntro = settings.get('hideIntro');
        hideIntro.value = true;
        this.mainDiv.style.display = 'none';
 The last line hides the dif in tooltip, but not the tooltip itself. As a _temporary_ workaround,
 "this.mainDiv.ownerDocument.documentElement" could be used instead of "this.mainDiv"

> screenshot:   https://dl.dropboxusercontent.com/s/pv2darf3q1gdm8a/GCLI%20tooltip%20doesn%27t%20hide%20completely%20when%20I%20press%20%27Got%20it%21%27%202015.11.09%2002-25-39.png?dl=0

Comment 4

[Lawrence Mandel [:lmandel] (use needinfo)]

Joe - Dup bug 1265417 is marked as a regression. This is user visible. Do we need to prioritize a fix for this bug?

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

Marking as a regression as per details in bug 1265417.

Comment 6

[arni2033]

s/the dif/the div/   (in comment 0)
This was caused by bug 933727 - looking at pushlog in 1265417

Comment 7

[Joe Walker [:jwalker]]

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #4)
> Joe - Dup bug 1265417 is marked as a regression. This is user visible. Do we
> need to prioritize a fix for this bug?

Yes, we do. Thanks for the reminder.

Comment 8

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Tracking, recent regression.

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

This is not a recent regression, it's too late to fix for Fx47.

Comment 10

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Filter under Floccinaucinihilipilification

Comment 11

[Joe Walker [:jwalker]]

P1 is "urgent, drop other work", and I don't think this is that. Regrading to P2.

Comment 12

[Joe Walker [:jwalker]]

So this kind of bad, but the logic for it not being P1, is that we'd not dropped everything to work on it. But perhaps we should have done. I'd assumed that it was a tricky fix, but it struck me that perhaps there was an easy fix, we could probably just remove the block at https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/developer-toolbar.js#534. 
Might you have time to check if that works Mike?

Comment 13

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Yup, sounds easy but I remember the GCLI panels being... playful.

I'll get right onto it captain.

Comment 14

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: 1244584-make-gcli-firstrun-tooltip-hide.diff

Turned out to be difficult to gain access to the actual panel rather than the iframe contents inside.

Now we just pass the panel into maybeShowIntro and call outputPanel.remove() in onGotIt().

Comment 15

[Joe Walker [:jwalker]]

Comment on attachment 8767135 [details] [diff] [review]
1244584-make-gcli-firstrun-tooltip-hide.diff

Review of attachment 8767135 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/02f60237d69a
Make GCLI tooltip hide after the first run experience r=jwalker

Comment 17

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/02f60237d69a

Comment 18

[Gerry Chang [:gchang]]

Hi Michael, do you want to uplift this for 48/49 if this patch is not too risky.

Comment 19

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8767135 [details] [diff] [review]
1244584-make-gcli-firstrun-tooltip-hide.diff

Approval Request Comment
[Feature/regressing bug #]: 1244584
[User impact if declined]: Panel that won't fully disappear.
[Describe test coverage new/current, TreeHerder]: No test needed.
[Risks and why]: Low risk... we just close the panel from the appropriate location.
[String/UUID change made/needed]: None

Comment 20

[Gerry Chang [:gchang]]

Comment on attachment 8767135 [details] [diff] [review]
1244584-make-gcli-firstrun-tooltip-hide.diff

Review of attachment 8767135 [details] [diff] [review]:
-----------------------------------------------------------------

This patch fixes a regression. Take it in 48 beta 6 and aurora.

Comment 21

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/504830a7308e

Comment 22

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f1d263387b33

Comment 23

[Camelia Badau [:cbadau], Desktop QA]

I've reproduced the initial issue on Nightly 46.0a1 - Windows 7 64bit, on Firefox 48 Beta 2 - Ubuntu and Mac. 

Verified fixed on Windows 7 64bit, Ubuntu 14.04 64bit and Mac OSX 10.11 using latest Nightly 50.0a1 (buildID: 20160711034039), latest Aurora 49.0a2 (buildID: 20160711004013) and Firefox 48 Beta 6 (buildID: 20160706215822).