Closed Bug 1244596 Opened 8 years ago Closed 7 years ago

Intermittent e10s browser_revive_crashed_bg_tabs.js | Test timed out

Tracking

()

Status:

RESOLVED FIXED

Milestone:

Firefox 58

Tracking Flags:

Tracking

Status

e10s

---

firefox57

---

fixed

firefox58

---

fixed

People

(Reporter: philor, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:timing])

Attachments

(1 file)

Bug 1244596 - Re-order awaits on browser loads in browser_revive_crashed_bg_tabs.js to avoid intermittent failure. 7 years ago Mike Conley (:mconley) (:⚙️) 59 bytes, text/x-review-board-request	mikedeboer : review+	Details

Phil Ringnalda (:philor)

Reporter

Description

•

8 years ago

https://treeherder.mozilla.org/logviewer.html#?job_id=6942778&repo=fx-team

Tracy Walker [:tracy]

Updated

•

8 years ago

Blocks: e10s-tests

tracking-e10s: --- → +

Chris Peterson [:cpeterson]

Comment 1

•

8 years ago

Intermittent e10s test failure

Priority: -- → P5

Comment hidden (Intermittent Failures Robot)

2 failures in 814 pushes (0.002 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-beta: 2

Platform breakdown:
* osx-10-10: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1244596&startday=2017-06-12&endday=2017-06-18&tree=all

Comment hidden (Intermittent Failures Robot)

1 failures in 888 pushes (0.001 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 1

Platform breakdown:
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1244596&startday=2017-07-31&endday=2017-08-06&tree=all

Comment hidden (Intermittent Failures Robot)

1 failures in 901 pushes (0.001 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 1

Platform breakdown:
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1244596&startday=2017-08-07&endday=2017-08-13&tree=all

Comment hidden (Intermittent Failures Robot)

1 failures in 908 pushes (0.001 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 1

Platform breakdown:
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1244596&startday=2017-08-21&endday=2017-08-27&tree=all

Comment hidden (Intermittent Failures Robot)

27 failures in 1032 pushes (0.026 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 16
* mozilla-central: 6
* mozilla-inbound: 4
* try: 1

Platform breakdown:
* linux32: 12
* linux64: 7
* linux64-stylo-disabled: 4
* linux32-stylo-disabled: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1244596&startday=2017-09-11&endday=2017-09-17&tree=all

Joel Maher ( :jmaher ) (UTC -8)

Comment 7

•

7 years ago

50 failures in the last 7 days:
https://brasstacks.mozilla.com/orangefactor/index.html?display=Bug&bugid=1244596

all on linux opt/pgo- so a pickup in frequency over the last couple weeks.


:mikedeboer- can you help set the priority of fixing this bug and get this in a queue to get looked at when it seems appropriate.

Flags: needinfo?(mdeboer)

Whiteboard: [stockwell needswork]

Mike de Boer [:mikedeboer]

Comment 8

•

7 years ago

Well, I'm guessing at this point, but I think that Mike Conley's eyes on this would be even better. Mike, if this is too much atop your plate, please let me know and I'll take a look!

Flags: needinfo?(mdeboer) → needinfo?(mconley)

Comment hidden (Intermittent Failures Robot)

60 failures in 943 pushes (0.064 failures/push) were associated with this bug in the last 7 days. 

This is the #30 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 27
* mozilla-inbound: 22
* mozilla-central: 8
* try: 2
* oak: 1

Platform breakdown:
* linux64: 22
* linux32: 16
* linux64-stylo-disabled: 12
* linux32-stylo-disabled: 7
* macosx64-stylo-disabled: 2
* windows7-32-stylo-disabled: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1244596&startday=2017-09-18&endday=2017-09-24&tree=all

Comment hidden (Intermittent Failures Robot)

59 failures in 885 pushes (0.067 failures/push) were associated with this bug in the last 7 days. 

This is the #32 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 29
* mozilla-inbound: 19
* mozilla-central: 8
* try: 3

Platform breakdown:
* linux64: 30
* linux64-stylo-disabled: 11
* macosx64-stylo-disabled: 8
* linux32-stylo-disabled: 4
* linux32: 4
* linux64-nightly: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1244596&startday=2017-09-25&endday=2017-10-01&tree=all

Comment hidden (mozreview-request)

In this test, it was possible for browser2 to finish loading _before_ the
BrowserTestUtils.browserLoaded function we were awaiting on for browser1 had
yielded back to the test, meaning that by the time we got to run
BrowserTestUtils.browserLoaded(browser2), the browser was already done loading,
and browserLoaded would be waiting for a page load that would never occur.

Review commit: https://reviewboard.mozilla.org/r/186142/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186142/

Mike Conley (:mconley) (:⚙️)

Assignee

Comment 12

•

7 years ago

This survived --run-until-failure with chaos mode enabled, and also --verify, so I feel pretty confident on this.

Flags: needinfo?(mconley)

Mike Conley (:mconley) (:⚙️)

Assignee

Updated

•

7 years ago

Assignee: nobody → mconley

Mike de Boer [:mikedeboer]

Comment 13

•

7 years ago

mozreview-review

Comment on attachment 8914886 [details]
Bug 1244596 - Re-order awaits on browser loads in browser_revive_crashed_bg_tabs.js to avoid intermittent failure.

https://reviewboard.mozilla.org/r/186142/#review191428

LGTM, thanks for fixing this up!

Attachment #8914886 - Flags: review?(mdeboer) → review+

Pulsebot

Comment 14

•

7 years ago

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fed3d895225f
Re-order awaits on browser loads in browser_revive_crashed_bg_tabs.js to avoid intermittent failure. r=mikedeboer

Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)

Comment 15

•

7 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/fed3d895225f

Status: NEW → RESOLVED

Closed: 7 years ago

status-firefox58: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 58

Ryan VanderMeulen [:RyanVM]

Comment 16

•

7 years ago

bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/977d70f841b8

status-firefox57: --- → fixed

Joel Maher ( :jmaher ) (UTC -8)

Updated

•

7 years ago

Whiteboard: [stockwell needswork] → [stockwell fixed:timing]

Comment hidden (Intermittent Failures Robot)

27 failures in 824 pushes (0.033 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 13
* autoland: 10
* try: 2
* mozilla-central: 2

Platform breakdown:
* linux64: 8
* linux64-stylo-disabled: 7
* linux32: 5
* macosx64-stylo-disabled: 4
* linux32-stylo-disabled: 2
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1244596&startday=2017-10-02&endday=2017-10-08&tree=all

You need to log in before you can comment on or make changes to this bug.