Change link clicker UI favicon to Firefox Hello logo

RESOLVED FIXED

Status

P2
normal
Rank:
25
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: RT, Assigned: mancas)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

User Story

Acceptance criteria:
- Link clicker UI favicon uses the Hello logo

Attachments

(2 attachments)

Comment hidden (empty)
(Reporter)

Comment 1

3 years ago
Sevaan can you please provide the visual asset for the Hello logo to use as Favicon?
Rank: 25
User Story: (updated)
Flags: needinfo?(sfranks)
Priority: -- → P2
Created attachment 8714372 [details]
Hello Favicons
Flags: needinfo?(sfranks)
(Assignee)

Updated

3 years ago
Assignee: nobody → b.mcb
Status: NEW → ASSIGNED
Created attachment 8714721 [details] [review]
[loop] mancas:bug1244621 > mozilla:master
(Assignee)

Comment 4

3 years ago
Comment on attachment 8714721 [details] [review]
[loop] mancas:bug1244621 > mozilla:master

Hey Mark, can you review this, please?

Thanks
Attachment #8714721 - Flags: review?(standard8)
Comment on attachment 8714721 [details] [review]
[loop] mancas:bug1244621 > mozilla:master

I tried loading this on my mac, and on my retina display it looked reasonable, but on my non-retina it looked bad. The shadows weren't quite right.

I think since we've been given them, lets include the two new icons as well, from looking around and at (https://en.wikipedia.org/wiki/Favicon), I think changing the html to be:

    <link rel="shortcut icon" href="favicon.ico">
    <link rel="icon" type="image/png" sizes="16x16" href="favicon-16x16.png">
    <link rel="icon" type="image/png" sizes="32x32" href="favicon-32x32.png">

is probably the best option.
Attachment #8714721 - Flags: review?(standard8)
(Assignee)

Comment 6

3 years ago
Comment on attachment 8714721 [details] [review]
[loop] mancas:bug1244621 > mozilla:master

I've added favicons and changed the html as you suggested. Can you test it in your non-retina screen please?

Thank you
Attachment #8714721 - Flags: review?(standard8)
Comment on attachment 8714721 [details] [review]
[loop] mancas:bug1244621 > mozilla:master

Looks good. r=Standard8

Please check in with Mike & myself on irc before landing if its in the next hour or two, as we're syncing up to land other bugs at the moment.
Attachment #8714721 - Flags: review?(standard8) → review+
(Assignee)

Comment 8

3 years ago
Landed in master: https://github.com/mozilla/loop/commit/2679fdc299e104d96be172fd036037129cd9f79d
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.