1244644 - Update cssutils in addons-server and validator

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[ggrossetie]

Attachment: [e-mail]

* This error occurred during the submission of an add-on with the jpm sign command.

* The URL where you submitted the add-on: https://addons.mozilla.org/en-US/developers/upload/f5c6600ccc1b4d159d6e82832195899f

 * The approximate time you submitted the add-on, with timezone: 10:20 UTC+1

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

I can confirm on https://addons.mozilla.org/en-US/developers/addon/validate

Comment 2

[ggrossetie]

In the meantime how can I sign or upload a new version of my addon ? Thanks.

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Andy, can someone look into this one?

Comment 4

[Andy McKay]

21:18:10 amo.validator:ERROR Unexpected error during validation: ValueError: invalid literal for int() with base 16: '00a0|' :/usr/lib/python2.7/site-packages/validator/errorbundler.py:142
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/validator/submain.py", line 69, in prepare_package
    test_package(err, package, path, expectation, for_appversions)
  File "/usr/lib/python2.7/site-packages/validator/submain.py", line 165, in test_package
    test_inner_package(err, package, for_appversions)
  File "/usr/lib/python2.7/site-packages/validator/submain.py", line 375, in test_inner_package
    test_func(err, xpi_package)
  File "/usr/lib/python2.7/site-packages/validator/testcases/content.py", line 198, in test_packed_packages
    name_lower)
  File "/usr/lib/python2.7/site-packages/validator/testcases/content.py", line 402, in _process_file
    testendpoint_css.test_css_file(err, name, file_data)
  File "/usr/lib/python2.7/site-packages/validator/testcases/markup/csstester.py", line 35, in test_css_file
    context=context)
  File "/usr/lib/python2.7/site-packages/validator/testcases/markup/csstester.py", line 63, in _run_css_tests
    tok_type, value, line, position = tokens.next()
  File "/usr/lib/python2.7/site-packages/cssutils/tokenize2.py", line 184, in tokenize
    value = self.unicodesub(_repl, found)
  File "/usr/lib/python2.7/site-packages/cssutils/tokenize2.py", line 108, in _repl
    num = int(m.group(0)[1:], 16)
ValueError: invalid literal for int() with base 16: '00a0|'


data/css/asciidoctor.css:138:#header .details br+span#revremark:before{content:"\00a0|\00a0"}

Comment 5

[Andy McKay]

Note, an upgrade to cssutils 1.0.1 fixes this (or the author could slightly change their css).

Filed: https://github.com/mozilla/addons-server/issues/1686

Comment 6

[ggrossetie]

> or the author could slightly change their css

Ok but what is the alternative to "\00a0|\00a0" ?

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/amo-validator

https://github.com/mozilla/amo-validator/commit/7d83bdcd539dcc5824b32968f4a98ba1777373c8
Upgrade cssutils to 1.0.1 to fix unicode space parsing.

Fixes bug 1244644