Closed Bug 1244688 Opened 4 years ago Closed 4 years ago

Allow overriding SOURCE_REV_URL

Categories

(Toolkit :: Telemetry, defect, P1)

defect
Points:
2

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox44 --- wontfix
firefox45 + fixed
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: gfritzsche, Assigned: gfritzsche)

References

(Blocks 1 open bug)

Details

(Whiteboard: [measurement:client])

Attachments

(1 file)

Cloning bug 1241111 which had trouble landing so we can land the minimal patch for overriding SOURCE_REV_URL here:

When building Firefox outside of a mercurial repository (e.g. from source trees cloned off the official hg repo), we loose the SOURCE_REV_URL [0] definition.

This will prevent us from sending the correct Histogram.json revision [1] along with the main ping [2].

We should change configure.in [0] and allow overriding SOURCE_REV_URL there.

[0] - https://dxr.mozilla.org/mozilla-central/rev/a77b73c7723e1060993045fb31eb2f0a30473486/configure.in#8742
[1] - https://dxr.mozilla.org/mozilla-central/rev/b67316254602a63bf4e568198a5c7d3288a9db27/toolkit/components/telemetry/TelemetrySession.jsm#954
[2] - https://gecko.readthedocs.org/en/latest/toolkit/components/telemetry/telemetry/main-ping.html
Attachment #8714303 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/20a1b9d469bb
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Comment on attachment 8714303 [details] [diff] [review]
Allow overriding SOURCE_REV_URL with external repository information

Approval Request Comment
[Feature/regressing bug #]: Data reporting / Telemetry
[User impact if declined]: This is required for correct Telemetry data from Ubuntu.
[Describe test coverage new/current, TreeHerder]: Fine on try, took this through manual testing scenarios
[Risks and why]: Low-risk, this version is very contained to just changing one define that is only used for Telemetry.
[String/UUID change made/needed]: None.
Attachment #8714303 - Flags: approval-mozilla-beta?
Attachment #8714303 - Flags: approval-mozilla-aurora?
Just out of curiousity, is the change from node|short to node in the template intentional?
Yes - the short version is actually prone to collisions and should only be used for short-term use-cases.
I checked in #hg - we have a few broken uses of this across the tree, triggering things like bug 1191051 and bug 1175655.
Comment on attachment 8714303 [details] [diff] [review]
Allow overriding SOURCE_REV_URL with external repository information

Fix for telemetry from Ubuntu, please uplift to aurora and beta.
Attachment #8714303 - Flags: approval-mozilla-beta?
Attachment #8714303 - Flags: approval-mozilla-beta+
Attachment #8714303 - Flags: approval-mozilla-aurora?
Attachment #8714303 - Flags: approval-mozilla-aurora+
[Tracking Requested - why for this release]:
Moving the tracking flag here per bug 1233687, comment 28.
You need to log in before you can comment on or make changes to this bug.