Closed Bug 1244726 Opened 4 years ago Closed 4 years ago

Windows nsDownloadManager.cpp "error C2338" build bustage with --disable-safe-browsing set

Categories

(Core :: DOM: Core & HTML, defect)

Unspecified
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: RyanVM, Assigned: aleth)

References

Details

Attachments

(1 file)

Fallout from bug 1241764 apparently. Kyle, presumably an include issue?

mozilla-central\objdir-fx-64\dist\include\nsCOMPtr.h(394) : error C2338: nsCOMPtr only works for types with IIDs.  Either use RefPtr; add an IID to your type with NS_DECLARE_STATIC_IID_ACCESSOR/NS_DEFINE_STATIC_IID_ACCESSOR; or make the nsCOMPtr point to a base class with an IID.
        mozilla-central\objdir-fx-64\dist\include\nsCOMPtr.h(389) : while compiling class template member function 'void nsCOMPtr<mozIDOMWindowProxy>::assert_validity(void)'
        mozilla-central\objdir-fx-64\dist\include\nsCOMPtr.h(430) : see reference to function template instantiation 'void nsCOMPtr<mozIDOMWindowProxy>::assert_validity(void)' being compiled
        mozilla-central/toolkit/components/downloads/nsDownloadManager.cpp(2576) : see reference to class template instantiation 'nsCOMPtr<mozIDOMWindowProxy>' being compiled
Flags: needinfo?(khuey)
Looks like the same issue as bug 1241764 comment 9.
Flags: needinfo?(khuey)
Not sure this is the best solution, but here it is, fwiw.
Attachment #8714323 - Flags: review?(khuey)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/16d38eb3a754
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.