Remove expired histogram probes

RESOLVED FIXED in Firefox 47

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

unspecified
Firefox 47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8714317 [details]
MozReview Request: Bug 1244727 - Remove expired histogram probes. r=mfinkle

Review commit: https://reviewboard.mozilla.org/r/33013/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33013/
Attachment #8714317 - Flags: review?(mark.finkle)
Comment on attachment 8714317 [details]
MozReview Request: Bug 1244727 - Remove expired histogram probes. r=mfinkle

https://reviewboard.mozilla.org/r/33013/#review29933

::: mobile/android/base/java/org/mozilla/gecko/db/LocalURLMetadata.java
(Diff revision 1)
> -        Telemetry.addToHistogram("FENNEC_TILES_CACHE_HIT", data.size());

ahunt has been in this code recently. I wonder if he has any reason to look at the existing data?
Attachment #8714317 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 4

3 years ago
(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 8714317 [details]
> MozReview Request: Bug 1244727 - Remove expired histogram probes. r=mfinkle
> 
> https://reviewboard.mozilla.org/r/33013/#review29933
> 
> ::: mobile/android/base/java/org/mozilla/gecko/db/LocalURLMetadata.java
> (Diff revision 1)
> > -        Telemetry.addToHistogram("FENNEC_TILES_CACHE_HIT", data.size());
> 
> ahunt has been in this code recently. I wonder if he has any reason to look
> at the existing data?

This expired in version 40, so there won't be any recent data.

We could recreate these probes if we think the data would be valuable.
Flags: needinfo?(ahunt)

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b98399791865
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 8714317 [details]
> MozReview Request: Bug 1244727 - Remove expired histogram probes. r=mfinkle
> 
> https://reviewboard.mozilla.org/r/33013/#review29933
> 
> ::: mobile/android/base/java/org/mozilla/gecko/db/LocalURLMetadata.java
> (Diff revision 1)
> > -        Telemetry.addToHistogram("FENNEC_TILES_CACHE_HIT", data.size());
> 
> ahunt has been in this code recently. I wonder if he has any reason to look
> at the existing data?

My changes were just adding an extra field to the data in the cache, but caching behaviour (and the resulting data.size() ) shouldn't be affected, so I don't think there's much value for me in keeping this around.
Flags: needinfo?(ahunt)
You need to log in before you can comment on or make changes to this bug.