1244727 - Remove expired histogram probes

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1244727 - Remove expired histogram probes. r=mfinkle

Review commit: https://reviewboard.mozilla.org/r/33013/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33013/

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8714317 [details]
MozReview Request: Bug 1244727 - Remove expired histogram probes. r=mfinkle

https://reviewboard.mozilla.org/r/33013/#review29933

::: mobile/android/base/java/org/mozilla/gecko/db/LocalURLMetadata.java
(Diff revision 1)
> -        Telemetry.addToHistogram("FENNEC_TILES_CACHE_HIT", data.size());

ahunt has been in this code recently. I wonder if he has any reason to look at the existing data?

Comment 3

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/cd18c8af8b56f127877aeae417139868cc96a9e5
Bug 1244727 - Remove expired histogram probes. r=mfinkle

Comment 4

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 8714317 [details]
> MozReview Request: Bug 1244727 - Remove expired histogram probes. r=mfinkle
> 
> https://reviewboard.mozilla.org/r/33013/#review29933
> 
> ::: mobile/android/base/java/org/mozilla/gecko/db/LocalURLMetadata.java
> (Diff revision 1)
> > -        Telemetry.addToHistogram("FENNEC_TILES_CACHE_HIT", data.size());
> 
> ahunt has been in this code recently. I wonder if he has any reason to look
> at the existing data?

This expired in version 40, so there won't be any recent data.

We could recreate these probes if we think the data would be valuable.

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/b98399791865c79a4c8d584252dcc6f0e0853c7c
Bug 1244727 - Remove expired histogram probes. r=mfinkle

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b98399791865

Comment 7

[Andrzej Hunt :ahunt]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 8714317 [details]
> MozReview Request: Bug 1244727 - Remove expired histogram probes. r=mfinkle
> 
> https://reviewboard.mozilla.org/r/33013/#review29933
> 
> ::: mobile/android/base/java/org/mozilla/gecko/db/LocalURLMetadata.java
> (Diff revision 1)
> > -        Telemetry.addToHistogram("FENNEC_TILES_CACHE_HIT", data.size());
> 
> ahunt has been in this code recently. I wonder if he has any reason to look
> at the existing data?

My changes were just adding an extra field to the data in the cache, but caching behaviour (and the resulting data.size() ) shouldn't be affected, so I don't think there's much value for me in keeping this around.