Closed Bug 1244734 Opened 4 years ago Closed 4 years ago

crash in java.lang.NullPointerException: at org.mozilla.gecko.BrowserApp.enterEditingMode(BrowserApp.java)

Categories

(Firefox for Android :: Awesomescreen, defect, critical)

Unspecified
Android
defect
Not set
critical

Tracking

()

RESOLVED FIXED
Firefox 47
Tracking Status
firefox46 + fixed
firefox47 + fixed
fennec 46+ ---

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-bf8b0657-5a2b-4ef0-b0fc-828962160130.
=============================================================

tab.getURL() can return null:
http://hg.mozilla.org/releases/mozilla-aurora/annotate/tip/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#l2194
Crash Signature: [@ java.lang.NullPointerException: at org.mozilla.gecko.BrowserApp.enterEditingMode(BrowserApp.java)] → [@ java.lang.NullPointerException: at org.mozilla.gecko.BrowserApp.enterEditingMode(BrowserApp.java)] [@ java.lang.NullPointerException: Attempt to invoke virtual method ''boolean java.lang.String.isEmpty()'' on a null object reference at org.mozilla.gec…
Comment on attachment 8714381 [details]
MozReview Request: Bug 1244734 - Handle a null tab URL in enterEditingMode. r=liuche

https://reviewboard.mozilla.org/r/33053/#review29861
Attachment #8714381 - Flags: review?(liuche) → review+
https://hg.mozilla.org/mozilla-central/rev/7c02b36fa96e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Comment on attachment 8714381 [details]
MozReview Request: Bug 1244734 - Handle a null tab URL in enterEditingMode. r=liuche

Approval Request Comment
[Feature/regressing bug #]: Bug 1022464.

[User impact if declined]: Crash.

[Describe test coverage new/current, TreeHerder]: Tested manually with local build, could not reproduce crash so we'll have to look at crash stats to verify this fix.

[Risks and why]: Low-risk, some small changes to logic to avoid calling a method on a null object.

[String/UUID change made/needed]: None.
Attachment #8714381 - Flags: approval-mozilla-aurora?
Tracking and marking affected for 46+ since this is a regression from 46.
Comment on attachment 8714381 [details]
MozReview Request: Bug 1244734 - Handle a null tab URL in enterEditingMode. r=liuche

Crash fix for recent regression, please uplift to aurora.
Attachment #8714381 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.