1244735 - Preference to control partial present

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

Create gfx.partialupdates.force preference; the default is 0, which leaves us with the automatic behaviour - disabled on Nvidia, enabled elsewhere.  Value > 0 forces partial updates everywhere.  Value of < 0 disables partial updates everywhere.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: MozReview Request: Bug 1244735: Preference to override the default behaviour for partial present. r?jrmuizel

Review commit: https://reviewboard.mozilla.org/r/33031/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33031/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8714341 [details]
MozReview Request: Bug 1244735: Preference to override the default behaviour for partial present. r?jrmuizel

https://reviewboard.mozilla.org/r/33031/#review29821

::: gfx/layers/d3d11/CompositorD3D11.cpp:1136
(Diff revision 1)
> +                                partialPresentPref < 0 ? false :

The parenthesis around (partialPresentPref > 0) is inconsistent with this line.

It might also be easier to read this if it wasn't a single expression.

i.e.

allowPartialPresent = true;
if (partialPresentPref > 0)
    allowPartialPresent = true;
else if (partialPresentPref < 0)
    allowPartialPresent = false;
else if (vendorID.EqualsLiteral("0x10de") && !WARP())
    allowPartialPresent = fale;

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Bug 1244735: Preference to override the default behaviour for partial present. Carry r=jrmuizel

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea2300e05e30

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8982ed90d8e6

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8982ed90d8e6