1244760 - DownloadContentService: Consider using HttpsUrlConnection

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

* Our version of HttpClient does not support SNI (bug 765064). And after transfering the CDN to Cloudfront we'll require support for SNI (bug 1238742).

* DownloadContentService is just downloading stuff via simple GET requests. HttpsUrlConnection supports everything we need.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1244760 - DownloadContentService: Use HttpUrlConnection instead of HttpClient. r=rnewman

Review commit: https://reviewboard.mozilla.org/r/33077/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33077/

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8714426 [details]
MozReview Request: Bug 1244760 - DownloadContentService: Use HttpUrlConnection instead of HttpClient. r=rnewman

https://reviewboard.mozilla.org/r/33077/#review29999

::: mobile/android/base/java/org/mozilla/gecko/dlc/DownloadAction.java:262
(Diff revision 1)
> -                .setUserAgent(HardwareUtils.isTablet() ?
> +            HttpURLConnection connection = (HttpURLConnection) new URL(url).openConnection();

Set the system property `http.keepAlive` to `true` here. We want these to stay up.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/afc316a28da296cdc4208013d1598519628b6c63
Bug 1244760 - DownloadContentService: Use HttpUrlConnection instead of HttpClient. r=rnewman

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/afc316a28da2