Closed
Bug 1244761
Opened 8 years ago
Closed 8 years ago
Sync preferences pane is not keyboard accessible
Categories
(Firefox :: Settings UI, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox47 | --- | affected |
People
(Reporter: vladikoff, Assigned: vladikoff)
Details
Attachments
(1 file)
1.32 MB,
image/gif
|
Details |
The "Disconnect" (and "Manage Account") buttons do not behave like normal buttons ("Create Account" / "Sign In" aka noFxaSignUp). I cannot target those properly with an automated tester and I guess this is also bad for accessibility reasons. This blocks https://github.com/mozilla/fxa/issues/104. See attached gif for details. Let me know if there are any questions.
Comment 1•8 years ago
|
||
The problem seems to be that we are using "click" handlers instead of "command". eg, the following patch fixes the disconnect and manage buttons: diff --git a/browser/components/preferences/in-content/sync.js b/browser/components/preferences/in-c ontent/sync.js index 8d58f11..d845717 100644 --- a/browser/components/preferences/in-content/sync.js +++ b/browser/components/preferences/in-content/sync.js @@ -271,9 +271,9 @@ var gSyncPane = { gSyncPane.signIn(); return false; }); - setEventListener("verifiedManage", "click", + setEventListener("verifiedManage", "command", gSyncPane.manageFirefoxAccount); - setEventListener("fxaUnlinkButton", "click", function () { + setEventListener("fxaUnlinkButton", "command", function () { but there are a number of other "click" handlers that look suspect (eg, the various links etc). We should fix these all at once.
Summary: Firefox Account "Disconnect" button is not keyboard accessible → Sync preferences pane is not keyboard accessible
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → vlad
Version: 47 Branch → 48 Branch
Assignee | ||
Comment 2•8 years ago
|
||
Fixed via https://github.com/mozilla/gecko-dev/commit/eb2c6cbfc2631092688aa1e7ba18d5bb0b37cc25
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•