SupportUtils.URLForTopic should use languageIdentifier instead of localeIdentifier

RESOLVED FIXED

Status

()

Firefox for iOS
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: st3fan, Assigned: st3fan)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios2.0+)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
SupportUtils.URLForTopic should use languageIdentifier instead of localeIdentifier. So that en-US ends up in the URL instead of en_US.
(Assignee)

Comment 1

2 years ago
Created attachment 8714429 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1489

This patch makes SupportUtils.URLForTopic use the *language identifier* instead of the *locale identifier*.
Attachment #8714429 - Flags: review?(sleroux)
Comment on attachment 8714429 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1489

LGTM!
Attachment #8714429 - Flags: review?(sleroux) → review+
(Assignee)

Comment 3

2 years ago
https://github.com/mozilla/firefox-ios/commit/36cb258e1f1dac94fa36639b5ca41aff872ca816
(Assignee)

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.