Closed Bug 1244859 Opened 4 years ago Closed 4 years ago
Remove trailing slash from telemetry ping url
13:12 <@mreid> mcomella: you should remove that trailing slash though 13:12 <@mreid> (it doesn't appear to affect anything on the server, it's just not to-spec) 13:13 <mcomella> mreid: So `.../buildId` as opposed to `.../buildId/` ? 13:13 <@mreid> mcomella: yep
It was not to-spec (though it doesn't appear to have an effect on how the server reads the data). Review commit: https://reviewboard.mozilla.org/r/33097/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33097/
Attachment #8714470 - Flags: review?(mark.finkle)
Only bothering to get a review so we can uplift later.
Comment on attachment 8714470 [details] MozReview Request: Bug 1244859 - Remove trailing slash in telemetry urls. r=mfinkle r=mfinkle https://reviewboard.mozilla.org/r/33097/#review29931
Attachment #8714470 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/integration/fx-team/rev/3e53d5cf6400fba69885bd2283e9a23976c7131d Bug 1244859 - Remove trailing slash in telemetry urls. r=mfinkle r=mfinkle
4 years ago
tracking-fennec: --- → 45+
(It's not strictly necessary for bug 1205835 though, just an optimization)
Comment on attachment 8714470 [details] MozReview Request: Bug 1244859 - Remove trailing slash in telemetry urls. r=mfinkle r=mfinkle This is a micro-optimization on the implementation in bug 1205835, which must be uplifted first. Approval Request Comment [Feature/regressing bug #]: bug 1205835. [User impact if declined]: Users send an extra byte (the trailing url slash) when requesting a url. Otherwise, no impact. It's not technically correct according to the server spec but it handles it gracefull. [Describe test coverage new/current, TreeHerder]: Tested locally. [Risks and why]: Extremely low – we remove a character from a url string. Worst case, we upload to the wrong url and break uploads. [String/UUID change made/needed]: None
Comment on attachment 8714470 [details] MozReview Request: Bug 1244859 - Remove trailing slash in telemetry urls. r=mfinkle r=mfinkle Minor change, taking it. Should be in 45 beta 4.
This can't be uplifted without bug 1205835 as it changes files introduced in it. As such, it looks like these uplifted patches created the files in the state they build on top of, when they should be changing one line. Can this get backed out until bug 1205835 lands?
This (and probably a bunch of the related uplift requests) needs to be rebased to work around the lack of bug 1107811 on the release branches.
I had to back this out on both branches so that everything else could land cleanly and in the correct order before finally relanding it. The backouts are in the following commits: https://hg.mozilla.org/releases/mozilla-aurora/rev/b923a7b09924 https://hg.mozilla.org/releases/mozilla-beta/rev/9b566531611e
Wes did it. Michael, do we want to land this again? Thanks
Flags: needinfo?(sledru) → needinfo?(michael.l.comella)
(In reply to Sylvestre Ledru [:sylvestre] from comment #17) > Wes did it. > Michael, do we want to land this again? Thanks This is already landed – the commits are posted out of order. The backout in comment 16 occurred before the relanding in comment 15 & comment 14.
You need to log in before you can comment on or make changes to this bug.