Closed Bug 1244870 Opened 4 years ago Closed 2 years ago

[CID 1351139] Uninitialized 'err' in OmxCommonVideoConfig::Apply()

Categories

(Core :: Audio/Video: Playback, defect, P3)

Product:
Core
Component:
Audio/Video: Playback
Version:
43 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: gerald, Assigned: jeanluc.bonnafoux)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1244870 - initialization of err variable
59 bytes, text/x-review-board-request
jya
: review+
Details 
In dom/media/platforms/omx/OmxPlatformLayer.cpp:
> 98  OMX_ERRORTYPE Apply(OmxPlatformLayer& aOmx, const VideoInfo& aInfo) override
> 99  {
    1. var_decl: Declaring variable err without initializer.
>100    OMX_ERRORTYPE err;
>101    OMX_PARAM_PORTDEFINITIONTYPE def;
>102
>103    // Set up in/out port definition.
>104    nsTArray<uint32_t> ports;
>105    GetOmxPortIndex(ports);
    2. No elements left in ports, leaving loop
>106    for (auto idx : ports) {
>[...]
>129    }
    CID 1351139 (#1 of 1): Uninitialized scalar variable (UNINIT)3. uninit_use: Using uninitialized value err.
>130    return err;
>131  }
Summary: [CID 1351139} Uninitialized 'err' in OmxCommonVideoConfig::Apply() → [CID 1351139] Uninitialized 'err' in OmxCommonVideoConfig::Apply()
Mass change P2 -> P3
Priority: P2 → P3
Comment on attachment 8969752 [details]
Bug 1244870 - initialization of err variable

https://reviewboard.mozilla.org/r/238564/#review244884

::: dom/media/platforms/omx/OmxPlatformLayer.cpp:57
(Diff revision 1)
> -  OMX_ERRORTYPE err;
> +  OMX_ERRORTYPE err = OMX_ErrorNone;
>  
>    OMX_PARAM_PORTDEFINITIONTYPE def;
>    InitOmxParameter(&def);
>    def.nPortIndex = aOmx.OutputPortIndex();
>    err = aOmx.GetParameter(OMX_IndexParamPortDefinition, &def, sizeof(def));

declare err as OMX_ERRORTYPE where it's first use.

eg.
OMX_ERRORTYPR err = aOmx.GetParameter(....)
Attachment #8969752 - Flags: review?(jyavenard) → review-
Comment on attachment 8969752 [details]
Bug 1244870 - initialization of err variable

https://reviewboard.mozilla.org/r/238564/#review245132

::: dom/media/platforms/omx/OmxPlatformLayer.cpp:57
(Diff revision 1)
> -  OMX_ERRORTYPE err;
> +  OMX_ERRORTYPE err = OMX_ErrorNone;
>  
>    OMX_PARAM_PORTDEFINITIONTYPE def;
>    InitOmxParameter(&def);
>    def.nPortIndex = aOmx.OutputPortIndex();
>    err = aOmx.GetParameter(OMX_IndexParamPortDefinition, &def, sizeof(def));

Thanks for the code review, i will add a patch accordingly.
Attachment #8969752 - Attachment is obsolete: true
Comment on attachment 8970656 [details]
Bug 1244870 - initialization of err variable

https://reviewboard.mozilla.org/r/239400/#review245694
Attachment #8970656 - Flags: review?(jyavenard) → review+
Assignee: nobody → jeanluc.bonnafoux
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/64583d3e0f6f
initialization of err variable r=jya
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/64583d3e0f6f
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.