1244870 - [CID 1351139] Uninitialized 'err' in OmxCommonVideoConfig::Apply()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

In dom/media/platforms/omx/OmxPlatformLayer.cpp:
> 98  OMX_ERRORTYPE Apply(OmxPlatformLayer& aOmx, const VideoInfo& aInfo) override
> 99  {
    1. var_decl: Declaring variable err without initializer.
>100    OMX_ERRORTYPE err;
>101    OMX_PARAM_PORTDEFINITIONTYPE def;
>102
>103    // Set up in/out port definition.
>104    nsTArray<uint32_t> ports;
>105    GetOmxPortIndex(ports);
    2. No elements left in ports, leaving loop
>106    for (auto idx : ports) {
>[...]
>129    }
    CID 1351139 (#1 of 1): Uninitialized scalar variable (UNINIT)3. uninit_use: Using uninitialized value err.
>130    return err;
>131  }

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Mass change P2 -> P3

Comment 2

[jbonnafo]

Attachment: Bug 1244870 - initialization of err variable

Review commit: https://reviewboard.mozilla.org/r/238564/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238564/

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8969752 [details]
Bug 1244870 - initialization of err variable

https://reviewboard.mozilla.org/r/238564/#review244884

::: dom/media/platforms/omx/OmxPlatformLayer.cpp:57
(Diff revision 1)
> -  OMX_ERRORTYPE err;
> +  OMX_ERRORTYPE err = OMX_ErrorNone;
>  
>    OMX_PARAM_PORTDEFINITIONTYPE def;
>    InitOmxParameter(&def);
>    def.nPortIndex = aOmx.OutputPortIndex();
>    err = aOmx.GetParameter(OMX_IndexParamPortDefinition, &def, sizeof(def));

declare err as OMX_ERRORTYPE where it's first use.

eg.
OMX_ERRORTYPR err = aOmx.GetParameter(....)

Comment 4

[jbonnafo]

Comment on attachment 8969752 [details]
Bug 1244870 - initialization of err variable

https://reviewboard.mozilla.org/r/238564/#review245132

::: dom/media/platforms/omx/OmxPlatformLayer.cpp:57
(Diff revision 1)
> -  OMX_ERRORTYPE err;
> +  OMX_ERRORTYPE err = OMX_ErrorNone;
>  
>    OMX_PARAM_PORTDEFINITIONTYPE def;
>    InitOmxParameter(&def);
>    def.nPortIndex = aOmx.OutputPortIndex();
>    err = aOmx.GetParameter(OMX_IndexParamPortDefinition, &def, sizeof(def));

Thanks for the code review, i will add a patch accordingly.

Comment 5

[jbonnafo]

Attachment: Bug 1244870 - initialization of err variable

Review commit: https://reviewboard.mozilla.org/r/239400/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239400/

Comment 6

[Jean-Yves Avenard [:jya]]

Comment on attachment 8970656 [details]
Bug 1244870 - initialization of err variable

https://reviewboard.mozilla.org/r/239400/#review245694

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64583d3e0f6f
initialization of err variable r=jya

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/64583d3e0f6f