1244875 - Refactor JNI template classes

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

I've been wanting to do a refactor of JNI template classes for a while, to improve the efficiency of using JNI. These patches should improve the performance of using the JNI Ref classes due to less TLS access, and there is a 10kB decrease in libxul size on try.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Refactor JNI templates (v1)

Improve the performance of JNI calls by making JNI calls require a
Context object. LocalRef inherits from Context and can make calls
directly. Non-local Ref classes will generate a Context object when
making a call. The patch also makes the template design cleaner in
several cases.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Update binding generator (v1)

Update the automatic binding generator to match the JNI template
changes.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Update JNI usages (v1)

Update JNI usages to match the changes in JNI templates.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Update auto-generated bindings (r=me)

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/621d2bd7feea
https://hg.mozilla.org/integration/mozilla-inbound/rev/1294093ae14d
https://hg.mozilla.org/integration/mozilla-inbound/rev/491e5d709463
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb0087d80b92

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/621d2bd7feea
https://hg.mozilla.org/mozilla-central/rev/1294093ae14d
https://hg.mozilla.org/mozilla-central/rev/491e5d709463
https://hg.mozilla.org/mozilla-central/rev/cb0087d80b92