1244892 - Unhandled promise rejection in browser_dbg_scripts-switching-03.js

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[James Long (:jlongster)]

Fixed promise rejection tracking and now need to fix the following test taht is throwing an unhandled error:

devtools/client/debugger/test/mochitest/browser_dbg_scripts-switching-03.js

Comment 1

[James Long (:jlongster)]

Attachment: 1244892.patch

Would be good to get you to review these if you want to get more familiar with the UI.

This shows a nice property: we can manually fire changes to the UI to test what we want, without actually going through any server. Here, I'm fixing an unhandled rejection by not making it happen in the first place. I don't have a reference to the promise that is throwing it so I can't suppress it in the test. In normal code we *want* it to throw.

Comment 2

[Eddy Bruel [:ejpbruel]]

Comment on attachment 8714508 [details] [diff] [review]
1244892.patch

Review of attachment 8714508 [details] [diff] [review]:
-----------------------------------------------------------------

Right, I remember talking to you about this. One of the nice things about React is that you can emulate the actions that would have been dispatched if you had actually gone through the server. Since the unhandled promise rejection results from going through the server, this allows you to avoid it in the test, but still trigger it in normal operation.

Assuming that that's all correct, this patch looks good to me.

Thank you very much for assigning these to me, by the way. You're right, this is a great way for me to learn more about the UI. Please keep patches like this coming!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/6826dfd0e85b

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6826dfd0e85b