Closed Bug 1244912 Opened 4 years ago Closed 4 years ago
JSON Viewer: hide object summary when object is expanded
When an object is expanded we should hide the collapsed object summary to prevent unnecessary duplicate information. via bug 1223143 comment 7 > ## JSON tab - duplicate information when expanding an object > > When an object is expanded, the object summary is still displayed, resulting > in an unclear visual feedback, unclear hierarchy and duplicate information. > > In the attached "duplicate-information.png" screenshot, the information > "needsflag:false" is visible 3 times, but it’s only one data point.
Summary: JSON VIewer: hide object summary when object is expanded → JSON Viewer: hide object summary when object is expanded
Couldn't resist to fix one bug while testing the reload addon...
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Sorry for the long delay! Suggested patch works, but have an impact on any usage of the tree component. I am working on a generic tree (see bug 1247065) that supports nice customization and allows a better way how to solve this issue. That tree is just a step from landing and I'd like to give it a try and fix this properly. If that doesn't happens soon (this week or so), I'll approve this patch. Honza
Depends on: 1247065
Priority: -- → P3
Depends on: 1256757
Sorry, it took so long, but I had to solve blockers first. Patch attached. - Do not render the summary when object is expanded - Align toggle button + label to the top. Honza
Include test coverage in the same patch. Honza
Comment on attachment 8733377 [details] [diff] [review] bug1244912.patch Review of attachment 8733377 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for working on this!
Attachment #8733377 - Flags: review?(jryans) → review+
Thanks for quick review! Yet one try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=94772d280a54 Honza
You need to log in before you can comment on or make changes to this bug.