1244920 - JSON Viewer: display the corresponding brackets for the given type

Status: NEW

(DevTools :: JSON Viewer, defect, P3)

Description

[Bryan Clark (DevTools PM) [:clarkbw]]

Of course I defer to Helen here.  But my opinion is that with an object expanded I think we should wrap them in their rightful bracket.  Objects {} and Arrays []

Such that an object would look like this:
\/ obj {
  attribute: value
}

And an array
\/ arr [
  0 value
]

via bug 1223143 comment 7

> Since we already have the brackets anyway that indicate the type, why not go
> the full way and wrap the expanded values in the brackets? (See
> "proposal-compact-expanded.png".)

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Not activity here, moving to the backlog (P3)
Honza

Comment 3

[Zac Svoboda :zacnomore]

I'm ran into trouble on adding the closing bracket because it requires an extra row. Seems like I'll be modifying TreeView but maybe I could get away with just changing the passed render function. What seems like a good approach here?

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Sorry for the dealay!

It feels like this is general feature that should be supported by the TreeView component.
Bomsy, what do you think?

Comment 5

[Hubert Boma Manilla (:bomsy)]

Honza, yeah i agree other panels can benefit from it.

Zac, feel free to build it into the TreeView component and we can see how it goes.

Thanks